Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll checkbox/radio label into view #345

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

Robbert
Copy link
Contributor

@Robbert Robbert commented Dec 27, 2024

Currently the focus only makes sure the radio button or checkbox itself is in view, but this code:

  • makes sure the label for the radio button / checkbox is in view
  • makes sure there is no unecessary scrolling then the label is already visible

This is particularly useful for the dialog in step 2 at 400% zoom

@Robbert Robbert requested a review from Yolijn December 27, 2024 08:51
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
signalen-frontend-wcag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 8:51am

@Yolijn Yolijn merged commit 935cb61 into main Dec 27, 2024
8 checks passed
@Yolijn Yolijn deleted the feat/scroll-options branch December 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants