Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call maybeNetwork() from non-ui thread, fix background thread #1127

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

r10s
Copy link
Member

@r10s r10s commented Apr 6, 2021

targets #1085
closes #1128

for review, compare commit-by-commit.

@r10s r10s force-pushed the target-anr branch 5 times, most recently from 79c0fba to 1f00c0e Compare April 6, 2021 18:04
@r10s r10s changed the title call maybeNetwork() from non-ui thread call maybeNetwork() from non-ui thread, fix background thread Apr 6, 2021
@r10s r10s requested a review from cyBerta April 6, 2021 18:29
@r10s r10s force-pushed the target-anr branch 6 times, most recently from 0281952 to 36cbaed Compare April 8, 2021 11:23
@r10s
Copy link
Member Author

r10s commented Apr 8, 2021

merging that in to move forward, @cyBerta please have a look at the changes once you are back to keyboard and fine time for it :)

@r10s r10s merged commit ccaa844 into master Apr 8, 2021
@r10s r10s deleted the target-anr branch April 8, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

declare background task later and redeclare them as needed
1 participant