-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: add basic ChatView UIViewController #1810
Conversation
tested only in the emulator, showing the new chat controller, there is already the lag at the bottom of the screen, so, things do not get displayed instantly (as true eg. in the settings or in other apps) - i think, we should get a grip on that first: have a look to the bottom part of the screen: although, also for the old controller, the bubbles are already there, the overlay changes half a second after the screen is there: Screen.Recording.2023-02-15.at.19.31.04.mov |
I haven't seen this issue before, because I tested with emulators and devices that don't have this touchbar outside of the safe layout area of the screen. The reason why this bug appears seems to be related to the fact that these outside-areas are not updated during the transition. Please have a look at the current state again. I kept the commits small, so that the intention for the changes become more obvious. |
in the emulator, things look good - where they were buggy before as well. so, with high chance, the last commits changed the correct things :) i will try my real device tomorrow or monday, currently checking there if i got crashed wrt #1202 (comment) |
7ded0be
to
1c440a7
Compare
…utField. Animate TextInputField position on keyboard appearing/disappearing
… keyboard is shown
…cape and in case of safe areas
closing stale pr, we'll try to fix #1737 more on point |
TODO: