Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: add basic ChatView UIViewController #1810

Closed
wants to merge 8 commits into from
Closed

Conversation

cyBerta
Copy link
Contributor

@cyBerta cyBerta commented Feb 15, 2023

  • ... containing a tableView and a dummy TextInputField.
  • Animate TextInputField position on keyboard appearing/disappearing

TODO:

  • fix message input bar max textview height on orientation change
  • ...

@r10s r10s marked this pull request as draft February 15, 2023 12:38
@r10s
Copy link
Member

r10s commented Feb 15, 2023

tested only in the emulator, showing the new chat controller, there is already the lag at the bottom of the screen, so, things do not get displayed instantly (as true eg. in the settings or in other apps) - i think, we should get a grip on that first:

have a look to the bottom part of the screen: although, also for the old controller, the bubbles are already there, the overlay changes half a second after the screen is there:

Screen.Recording.2023-02-15.at.19.31.04.mov

@cyBerta
Copy link
Contributor Author

cyBerta commented Feb 25, 2023

I haven't seen this issue before, because I tested with emulators and devices that don't have this touchbar outside of the safe layout area of the screen. The reason why this bug appears seems to be related to the fact that these outside-areas are not updated during the transition. Please have a look at the current state again. I kept the commits small, so that the intention for the changes become more obvious.

@r10s
Copy link
Member

r10s commented Feb 25, 2023

in the emulator, things look good - where they were buggy before as well. so, with high chance, the last commits changed the correct things :)

i will try my real device tomorrow or monday, currently checking there if i got crashed wrt #1202 (comment)

@r10s r10s force-pushed the chat_view_rewrite branch 2 times, most recently from 7ded0be to 1c440a7 Compare April 22, 2023 12:29
@r10s
Copy link
Member

r10s commented Oct 29, 2023

closing stale pr, we'll try to fix #1737 more on point

@r10s r10s closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed PRs and Issues
Development

Successfully merging this pull request may close these issues.

2 participants