shorten notification setup, fix potential crashes #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/notification-error-handling
branch
from
513cc3a to
d1ddd34
Compare
r10s
force-pushed
the
r10s/notification-error-handling
branch
from
d1ddd34 to
f92fd29
Compare
- log errors - force dispatching to main, this could be a source of crashes as `registerForNotifications()` was called at least partly on a background thread from the connectivity handler - when looking at examples, the additional check to getNotificationSettings() is redundant
r10s
force-pushed
the
r10s/notification-error-handling
branch
from
f92fd29 to
02d6ce0
Compare
r10s
changed the title
adbenitez
approved these changes
Dec 24, 2023
adbenitez
reviewed
Dec 24, 2023
Co-authored-by: Asiel Díaz Benítez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerForNotifications()was called at least partly on a background thread from the connectivity handlercmp #2009, #1882, #1202