Prevent hide on popup window losing focus, fixed escape key listener to close popup #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popup windows used to close immediately of loss of focus, and for some window managers this was instant, as focus can be directed to the mouse pointer instead of the most recent window. This fixes that, as well as fixing the escape key listener, that didn't function, as the listener was added to a window that was not focused at the time.
I can see the use of a popup disappearing on loss of focus, and if this becomes an issue, a cancel or X button might be the better way to go, just for compatibility reasons.