Regex tokens not working

[zekth]

These two tokens does not seem to work:

test('route with an extension regex 2', t => {
  t.plan(2)
  const findMyWay = FindMyWay({
    defaultRoute: (req) => {
      t.fail(`route not matched: ${req.url}`)
    }
  })
  findMyWay.on('GET', '/test/S/:file(^\\S+).png', () => {
    t.ok('regex match')
  })
  findMyWay.on('GET', '/test/D/:file(^\\D+).png', () => {
    t.ok('regex match')
  })
  findMyWay.lookup({ method: 'GET', url: '/test/S/foo.png', headers: {} }, null)
  findMyWay.lookup({ method: 'GET', url: '/test/D/foo.png', headers: {} }, null)
})

Ref:

• S : non whitespace character
• D : non digit character

Any clue why those does not work? Even with the allowUnsafeRegex is does not work.

[mcollina]

I don't know, this would probably be investigated. Maybe it's an escaping issue? Or we should pass some custom option when we create the Regexp?

[zekth]

I wanted to know if a known flaw. I'll dig it.

[jtarchie]

The capture group for both includes ^, which in this context means "asserts position at start of line". These aren't ever going to match because there is no start of line here.

[zekth]

The capture group for both includes ^, which in this context means "asserts position at start of line". These aren't ever going to match because there is no start of line here.

I'm not sure this is the case. As this test for example won't pass either:

find-my-way/test/regex.test.js

Lines 37 to 50 in 70844a9

	test('nested route with matching regex', t => {
	t.plan(1)
	const findMyWay = FindMyWay({
	defaultRoute: () => {
	t.fail('route not matched')
	}
	})
	findMyWay.on('GET', '/test/:id(^\\d+$)/hello', () => {
	t.ok('regex match')
	})
	findMyWay.lookup({ method: 'GET', url: '/test/12/hello', headers: {} }, null)
	})

[jtarchie]

It’s still looking for the start of line. What do you think the caret is suppose to be doing here?

[zekth]

In this context

  findMyWay.on('GET', '/test/:id(^\\d+$)/hello', () => {
    t.ok('regex match')
  })

  findMyWay.lookup({ method: 'GET', url: '/test/12/hello', headers: {} }, null)

The line passed to the regex test is 12 so it matches. Which is executed here:

find-my-way/index.js

Line 552 in 70844a9

if (!node.regex.test(decoded)) return null

This case works, so i don't get your point.

Even without ^ token, the test for \S and \D doesn't passe

But if you have a solution for this, raise a PR or a working example

[ivan-tymoshenko]

@mcollina @delvedor This can be closed.