Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constrainer overwrite #256

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fix constrainer overwrite #256

merged 1 commit into from
Apr 22, 2022

Conversation

ivan-tymoshenko
Copy link
Collaborator

@ivan-tymoshenko ivan-tymoshenko commented Apr 22, 2022 •
edited
Loading

Fixed #254

@ivan-tymoshenko ivan-tymoshenko mentioned this pull request Apr 22, 2022
Closed
@ivan-tymoshenko ivan-tymoshenko force-pushed the fix-constrainer-overwrite branch from 6bcfdb1 to 721c167 Compare April 22, 2022 17:33
climba03003
climba03003 reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the order of argument.
constrainer comes first then the other options.

It is more consistence in my eyes and storage usually not going to be removed / changed, but options depends on it will.

@ivan-tymoshenko ivan-tymoshenko force-pushed the fix-constrainer-overwrite branch from 721c167 to 597d1f1 Compare April 22, 2022 17:48
@ivan-tymoshenko
Copy link
Collaborator Author

I changed the order

climba03003
climba03003 approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@climba03003 climba03003 mentioned this pull request Apr 22, 2022
Merged
4 tasks
RafaelGSS
RafaelGSS approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mcollina
mcollina approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 70092fd into delvedor:main Apr 22, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the fix-constrainer-overwrite branch April 25, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@climba03003 climba03003 climba03003 approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

constraints will be overrided when multiple router created
4 participants
@ivan-tymoshenko @mcollina @climba03003 @RafaelGSS