Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
calculate_open_short
tosolvency_after_short
. And we now callsolvency_after_short
incalculate_open_short
. This diverges a bit from Solidity because we do not split theapply_open_short
function from thecalculate_open_short
function in rust. This means it was possible to get a valid answer fromcalculate_open_short
that would revert in the contract. That should be fixed, now.solvency_after_short(min_txn)
instead of the incorrect check it was doing.get_max_short
function from the preamble. We don't need all of the extra checks.agent.calculate_max_short
calculate_short_bonds_given_deposit
tomaybe_base_tolerance=1e10
(from1e9
) andmaybe_max_iterations=1_000
(from500
).