precision fixes

delvtech · Jan 2, 2025 · f016815 · f016815
1 parent 10ded33
commit f016815
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/contracts/src/instances/savings-usds-l2/SavingsUSDSL2Base.sol b/contracts/src/instances/savings-usds-l2/SavingsUSDSL2Base.sol
@@ -106,17 +106,29 @@ abstract contract SavingsUSDSL2Base is HyperdriveBase {
             address(_PSM),
             _shareAmount
         );
+
         // Withdrawing amounts to swapping SUSDS back for USDS in the PSM.
-        amountWithdrawn = _PSM.swapExactOut(
+        amountWithdrawn = _PSM.swapExactIn(
             address(_vaultSharesToken),
             address(_baseToken),
-            _convertToBase(_shareAmount) - 1, // minus 1 because the PSM swap function rounds up.
             _shareAmount,
+            _convertToBase(_shareAmount),
             _destination,
             0
         );
 
-        return _convertToBase(amountWithdrawn);
+        return amountWithdrawn;
+
+        // amountWithdrawn = _PSM.swapExactOut(
+        //     address(_vaultSharesToken),
+        //     address(_baseToken),
+        //     _convertToBase(_shareAmount) - 1, // minus 1 because the PSM swap function rounds up.
+        //     _shareAmount,
+        //     _destination,
+        //     0
+        // );
+
+        // return _convertToBase(amountWithdrawn);
     }
 
     /// @dev Process a withdrawal in vault shares and send the proceeds to the

diff --git a/test/utils/InstanceTest.sol b/test/utils/InstanceTest.sol
@@ -740,15 +740,10 @@ abstract contract InstanceTest is HyperdriveTest {
                 uint256 traderBaseAfter,
                 uint256 traderSharesAfter
             ) = getTokenBalances(address(trader));
-            assertApproxEqAbs(
-                hyperdriveBaseAfter,
-                hyperdriveBalancesBefore.baseBalance,
-                config.verifyWithdrawalTolerance
-            );
-            assertApproxEqAbs(
+            assertEq(hyperdriveBaseAfter, hyperdriveBalancesBefore.baseBalance);
+            assertEq(
                 traderBaseAfter,
-                traderBalancesBefore.baseBalance + baseProceeds,
-                config.verifyWithdrawalTolerance
+                traderBalancesBefore.baseBalance + baseProceeds
             );
 
             // Ensure that the shares balances were updated correctly.