Updated the instance tests to support fuzzing of new integrations #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
mcclurejt,
cashd and
sentilesdal
as code owners
Pull Request Test Coverage Report for Build 10115614749Details
💛 - Coveralls |
slundqui
approved these changes
Jul 25, 2024
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
mcclurejt
approved these changes
Jul 26, 2024
| @@ -80,14 +80,14 @@ contract AaveHyperdriveTest is InstanceTest { | |||
|
|
|||
| /// @dev Gets the extra data used to deploy Hyperdrive instances. | |||
| /// @return The extra data. | |||
| function getExtraData() internal pure override returns (bytes memory) { | |||
| function getExtraData() public pure override returns (bytes memory) { | |||
| return new bytes(0); | |||
| } | |||
|
|
|||
| /// @dev Converts base amount to the equivalent about in shares. | |||
| function convertToShares( | |||
There was a problem hiding this comment.
Why is this reimplemented rather than calling the public method on the hyperdrive instance?
There was a problem hiding this comment.
Good question. That method isn’t available before deployHyperdrive is called, and this is used within deployHyperdrive. We might be able to find a workaround in the future, but for now, we need this.
test/utils/HyperdriveTest.sol
Outdated
| @@ -1,6 +1,8 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| pragma solidity 0.8.20; | |||
|
|
|||
| import { console2 as console } from "forge-std/console2.sol"; | |||
|
|
|||
slundqui
reviewed
Jul 30, 2024
| @@ -110,12 +110,12 @@ contract AaveHyperdriveTest is InstanceTest { | |||
| /// @param _factory The address of the Hyperdrive factory. | |||
| function deployCoordinator( | |||
| address _factory | |||
| ) internal override returns (address) { | |||
| ) public override returns (address) { | |||
| vm.startPrank(alice); | |||
There was a problem hiding this comment.
I seem to be having trouble calling this contract's functions. My best guess is that I'm not using the alice account correctly from this function. Any chance we can either (1) expose the private key of alice, or (2) allow the account as an argument?
slundqui
reviewed
Jul 31, 2024
| @@ -110,12 +110,12 @@ contract AaveHyperdriveTest is InstanceTest { | |||
| /// @param _factory The address of the Hyperdrive factory. | |||
| function deployCoordinator( | |||
| address _factory | |||
| ) internal override returns (address) { | |||
| ) public override returns (address) { | |||
| vm.startPrank(alice); | |||
There was a problem hiding this comment.
I'm attempting to deploy this contract, then call this function to deploy the coordinator, but getting execution reverted on this line. Are cheatcodes supported when the contract is deployed?
|
Closing this since we found that this wasn't a viable path to fuzzing the instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues
Partially resolves: #1108.
Description
This PR makes several functions in the
InstanceTestharness public. This makes it possible to leverage this functionality on a mainnet fork to run fuzz tests against new integrations. This is the PR that should bring this system to the MCP (minimum crappy product). Some notable features that are absent are:accruefunction, although that will not be hard to add in a later PR.