Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morpho Blue cbETH/USDC Integration on Base #1168

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR adds a test suite and deployment tools for the Morpho Blue cbETH/USDC pool on Base.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just a question about the ts

Copy link

github-actions bot commented Sep 10, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 837c6c1 Previous: 252867b Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 193102 gas 192539 gas 0.2924% 🚨
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147755 gas 147745 gas 0.0068% 🚨
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 130146 gas 129673 gas 0.3648% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124885 gas 124841 gas 0.0352% 🚨
closeShort: max 277335 gas 400460 gas -30.7459%
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355921 gas 355900 gas 0.0059% 🚨
initialize: max 424801 gas 424801 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173863 gas 173764 gas 0.0570% 🚨
openLong: max 339778 gas 339778 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172649 gas 172269 gas 0.2206% 🚨
openShort: max 412391 gas 415052 gas -0.6411%
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 74567 gas 74784 gas -0.2902%
redeemWithdrawalShares: max 311225 gas 311225 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 216151 gas 216341 gas -0.0878%
removeLiquidity: max 403683 gas 403683 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10801217012

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.674%

Totals Coverage Status
Change from base Build 10799511329: 0.0%
Covered Lines: 2362
Relevant Lines: 2634

💛 - Coveralls

@jalextowle jalextowle added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit d990656 Sep 10, 2024
34 checks passed
@jalextowle jalextowle deleted the jalextowle/integration/morpho-cbeth-usdc-base branch September 10, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants