Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max spot price including flat fee #657

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Conversation

wakamex
Copy link
Contributor

@wakamex wakamex commented Nov 8, 2023

update max spot price calculations according to #655 (for open longs only)

@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2023

Coverage Status

coverage: 95.751%. remained the same
when pulling 41e32db on max_spot_price_include_flat_fee
into 8ab56c3 on main.

@wakamex wakamex force-pushed the max_spot_price_include_flat_fee branch from c732d10 to f43212d Compare November 10, 2023 16:48
Copy link

github-actions bot commented Nov 10, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 41e32db Previous: 6eec8aa Deviation Status
addLiquidity: min 1622 gas 755 gas 114.8344% 🚨
addLiquidity: avg 54725 gas 52286 gas 4.6647% 🚨
addLiquidity: max 98648 gas 97684 gas 0.9869% 🚨
checkpoint: min 1216 gas 558 gas 117.9211% 🚨
checkpoint: avg 48259 gas 47612 gas 1.3589% 🚨
checkpoint: max 97592 gas 99085 gas -1.5068%
closeLong: min 1690 gas 755 gas 123.8411% 🚨
closeLong: avg 24897 gas 24352 gas 2.2380% 🚨
closeLong: max 114354 gas 114894 gas -0.4700%
closeShort: min 1693 gas 713 gas 137.4474% 🚨
closeShort: avg 27706 gas 27113 gas 2.1871% 🚨
closeShort: max 109072 gas 113274 gas -3.7096%
initialize: min 1605 gas 706 gas 127.3371% 🚨
initialize: avg 179780 gas 178066 gas 0.9626% 🚨
initialize: max 254322 gas 252327 gas 0.7906% 🚨
openLong: min 736 gas 757 gas -2.7741%
openLong: avg 56244 gas 57711 gas -2.5420%
openLong: max 196013 gas 219289 gas -10.6143%
openShort: min 702 gas 712 gas -1.4045%
openShort: avg 55570 gas 57222 gas -2.8870%
openShort: max 194932 gas 218776 gas -10.8988%
redeemWithdrawalShares: min 1598 gas
redeemWithdrawalShares: avg 22367 gas
redeemWithdrawalShares: max 49853 gas
removeLiquidity: min 1661 gas 777 gas 113.7709% 🚨
removeLiquidity: avg 77183 gas 78355 gas -1.4958%
removeLiquidity: max 204563 gas 204374 gas 0.0925% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@wakamex wakamex force-pushed the max_spot_price_include_flat_fee branch from 19741b2 to f37b136 Compare November 11, 2023 20:07
@wakamex wakamex force-pushed the max_spot_price_include_flat_fee branch 6 times, most recently from 5fd0876 to f8c2433 Compare November 14, 2023 18:08
@wakamex wakamex force-pushed the max_spot_price_include_flat_fee branch 4 times, most recently from c6cb13b to 7c1dd3c Compare November 28, 2023 17:38
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this dude! This was a complicated feature, and you nailed it

@wakamex wakamex force-pushed the max_spot_price_include_flat_fee branch from 7c1dd3c to 41e32db Compare November 29, 2023 18:31
@wakamex wakamex merged commit 099d850 into main Nov 29, 2023
7 checks passed
@wakamex wakamex deleted the max_spot_price_include_flat_fee branch November 29, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants