-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max spot price including flat fee #657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamex
force-pushed
the
max_spot_price_include_flat_fee
branch
from
November 10, 2023 16:48
c732d10
to
f43212d
Compare
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
wakamex
force-pushed
the
max_spot_price_include_flat_fee
branch
from
November 11, 2023 20:07
19741b2
to
f37b136
Compare
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
jalextowle
reviewed
Nov 14, 2023
wakamex
force-pushed
the
max_spot_price_include_flat_fee
branch
6 times, most recently
from
November 14, 2023 18:08
5fd0876
to
f8c2433
Compare
jalextowle
reviewed
Nov 15, 2023
jalextowle
reviewed
Nov 15, 2023
jalextowle
reviewed
Nov 15, 2023
wakamex
force-pushed
the
max_spot_price_include_flat_fee
branch
4 times, most recently
from
November 28, 2023 17:38
c6cb13b
to
7c1dd3c
Compare
jalextowle
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on this dude! This was a complicated feature, and you nailed it
Co-authored-by: Alex Towle <[email protected]>
wakamex
force-pushed
the
max_spot_price_include_flat_fee
branch
from
November 29, 2023 18:31
7c1dd3c
to
41e32db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update max spot price calculations according to #655 (for open longs only)