Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename checkpoint exposure and normalize addliquidity event value #659

Merged
merged 3 commits into from
Nov 9, 2023
Merged

rename checkpoint exposure and normalize addliquidity event value #659

merged 3 commits into from
Nov 9, 2023

Conversation

jrhea
Copy link
Contributor

@jrhea jrhea commented Nov 8, 2023 •
edited
Loading

  • change checkpoint.longExposure to checkpoint.exposure
  • use contribution value directly when emitting event in addLiquidity for consistency (similar to how it is done in openLong)

@jrhea jrhea changed the title tbd rename checkpoint exposure and normalize addliquidity event value Nov 8, 2023
@jrhea jrhea requested a review from jalextowle November 8, 2023 23:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: bd31092 Previous: 6f067f9 Deviation Status
addLiquidity: min 755 gas 755 gas 0% 🟰
addLiquidity: avg 52287 gas 52224 gas 0.1206% 🚨
addLiquidity: max 97684 gas 97600 gas 0.0861% 🚨
checkpoint: min 558 gas 558 gas 0% 🟰
checkpoint: avg 47645 gas 47626 gas 0.0399% 🚨
checkpoint: max 99410 gas 99410 gas 0% 🟰
closeLong: min 755 gas 755 gas 0% 🟰
closeLong: avg 24170 gas 24301 gas -0.5391% ✅
closeLong: max 114894 gas 114894 gas 0% 🟰
closeShort: min 713 gas 713 gas 0% 🟰
closeShort: avg 27204 gas 27140 gas 0.2358% 🚨
closeShort: max 113274 gas 113274 gas 0% 🟰
initialize: min 706 gas 706 gas 0% 🟰
initialize: avg 178066 gas 178066 gas 0% 🟰
initialize: max 252327 gas 252327 gas 0% 🟰
openLong: min 757 gas 757 gas 0% 🟰
openLong: avg 57673 gas 57575 gas 0.1702% 🚨
openLong: max 219128 gas 219128 gas 0% 🟰
openShort: min 712 gas 712 gas 0% 🟰
openShort: avg 57023 gas 57068 gas -0.0789% ✅
openShort: max 218660 gas 218660 gas 0% 🟰
removeLiquidity: min 777 gas 777 gas 0% 🟰
removeLiquidity: avg 78309 gas 78310 gas -0.0013% ✅
removeLiquidity: max 204374 gas 204374 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2023 •
edited
Loading

Coverage Status

coverage: 97.592% (+0.003%) from 97.589%
when pulling bd31092 on rename-misc-fix
into 6f067f9 on main.

jalextowle
jalextowle approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrhea
Copy link
Contributor Author

jrhea commented Nov 9, 2023

image

@jrhea jrhea enabled auto-merge (squash) November 9, 2023 00:34
@jrhea jrhea merged commit 2f638cb into main Nov 9, 2023
6 checks passed
@jrhea jrhea deleted the rename-misc-fix branch November 9, 2023 04:31
@slundqui slundqui mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhea @coveralls @jalextowle