Zombie Interest

[jrhea]

This pr adds logic to allow hyperdrive LPs to collect interest from zombie positions

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: f086b1f	Previous: 099d850	Deviation	Status
addLiquidity: min	1600 gas	1622 gas	-1.3564%	✅
addLiquidity: avg	53399 gas	54725 gas	-2.4230%	✅
addLiquidity: max	99828 gas	98648 gas	1.1962%	🚨
checkpoint: min	1216 gas	1216 gas	0%	🟰
checkpoint: avg	49754 gas	48259 gas	3.0979%	🚨
checkpoint: max	114768 gas	97592 gas	17.5998%	🚨
closeLong: min	1690 gas	1690 gas	0%	🟰
closeLong: avg	27018 gas	24890 gas	8.5496%	🚨
closeLong: max	137971 gas	114354 gas	20.6525%	🚨
closeShort: min	1693 gas	1693 gas	0%	🟰
closeShort: avg	29286 gas	27649 gas	5.9206%	🚨
closeShort: max	110588 gas	108976 gas	1.4792%	🚨
initialize: min	1605 gas	1605 gas	0%	🟰
initialize: avg	181867 gas	179780 gas	1.1609%	🚨
initialize: max	256838 gas	254322 gas	0.9893%	🚨
openLong: min	736 gas	736 gas	0%	🟰
openLong: avg	54445 gas	56291 gas	-3.2794%	✅
openLong: max	179948 gas	196013 gas	-8.1959%	✅
openShort: min	702 gas	702 gas	0%	🟰
openShort: avg	53759 gas	55560 gas	-3.2415%	✅
openShort: max	177871 gas	194932 gas	-8.7523%	✅
redeemWithdrawalShares: min	1598 gas	1598 gas	0%	🟰
redeemWithdrawalShares: avg	20958 gas	22367 gas	-6.2995%	✅
redeemWithdrawalShares: max	51824 gas	49853 gas	3.9536%	🚨
removeLiquidity: min	1661 gas	1661 gas	0%	🟰
removeLiquidity: avg	76538 gas	77183 gas	-0.8357%	✅
removeLiquidity: max	212872 gas	204563 gas	4.0618%	🚨

This comment was automatically generated by workflow using github-action-benchmark.

[coveralls]

coverage: 95.764% (+0.1%) from 95.661%
when pulling f086b1f on zombie-interest
into 844fc0e on main.

[jalextowle]

Nice job on this! A few features that I was expecting are missing from this including paying out zombie interest on zombie shorts and giving some of the zombie interest to governance as a form of governance fees. It would be good to chat or talk about whether or not we want to do these things async.

[jrhea]

Nice job on this! A few features that I was expecting are missing from this including paying out zombie interest on zombie shorts and giving some of the zombie interest to governance as a form of governance fees. It would be good to chat or talk about whether or not we want to do these things async.

I was thinking that the decision on how/if to payout zombie interest to governance is a discussion that needs to happen independent of this

[jalextowle]

Nice job on this! A few features that I was expecting are missing from this including paying out zombie interest on zombie shorts and giving some of the zombie interest to governance as a form of governance fees. It would be good to chat or talk about whether or not we want to do these things async.

I was thinking that the decision on how/if to payout zombie interest to governance is a discussion that needs to happen independent of this

Okay, that sounds good to me.

[jalextowle]

Nice work! This is a dope feature, and it actually dropped our gas costs for a bunch of core functions.