Code

_distributeExcessIdle overhaul#688

Code

Merged

jalextowle merged 76 commits intomaindelvtech/hyperdrive:mainfrom jalextowle/feature/distribute-excess-idle-overhaul-2delvtech/hyperdrive:jalextowle/feature/distribute-excess-idle-overhaul-2Copy head branch name to clipboardDec 19, 2023

+5,655-3,269

Commits

Commits on Nov 21, 2023

• Cleaned up the calculatePresentValue function

  jalextowle

  committed
  f955eda

  Copy full SHA for f955eda

• Simplied the max buy case of calculatePresentValue

  jalextowle

  committed
  8c46fc3

  Copy full SHA for 8c46fc3

• Fixed the broken test

  jalextowle

  committed
  751fa49

  Copy full SHA for 751fa49

• Optimize the happy path of calculateCloseLong and calculateCloseShort

  jalextowle

  committed
  8dbbda6

  Copy full SHA for 8dbbda6

• Fixed the Rust tests

  jalextowle

  committed
  6c79343

  Copy full SHA for 6c79343

• Optimized calculatePresentValue

  jalextowle

  committed
  91ce575

  Copy full SHA for 91ce575

• Moved permitForAll to HyperdriveTarget0

  jalextowle

  committed
  0ff67c8

  Copy full SHA for 0ff67c8

• Addressed review feedback from @jrhea

  jalextowle

  committed
  c3d60e6

  Copy full SHA for c3d60e6

• Re-applied review feedback from @jrhea

  jalextowle

  committed
  3adeb6e

  Copy full SHA for 3adeb6e

• Cleaned up the comments a bit more in YieldSpaceMath

  jalextowle

  committed
  d2bb6d2

  Copy full SHA for d2bb6d2

Commits on Nov 27, 2023

• Merge remote-tracking branch 'origin/main' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  5048f70

  Copy full SHA for 5048f70

Commits on Nov 28, 2023

• Added a test to verify that the present value is monotonic when the pool is net long

  jalextowle

  committed
  edd6f59

  Copy full SHA for edd6f59

Commits on Nov 30, 2023

• Wrote out the outline of the new _distributeExcessIdle calculation

  jalextowle

  committed
  1dfc4fe

  Copy full SHA for 1dfc4fe

Commits on Dec 2, 2023

• Started testing calculateMaxShareReservesDelta

  jalextowle

  committed
  03b4c08

  Copy full SHA for 03b4c08

Commits on Dec 3, 2023

• Greatly improved the guessing methodology (it's still on the wrong side)

  jalextowle

  committed
  c319c24

  Copy full SHA for c319c24

Commits on Dec 4, 2023

• Got some initial unit tests working for the hard part of _distributeExcessIdle

  jalextowle

  committed
  d627729

  Copy full SHA for d627729

• Merge remote-tracking branch 'origin/main' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  4116a72

  Copy full SHA for 4116a72

Commits on Dec 5, 2023

• Fixed a few tests

  jalextowle

  committed
  d27ccff

  Copy full SHA for d27ccff

• Started the overhaul of removeLiquidity

  jalextowle

  committed
  8629d75

  Copy full SHA for 8629d75

• Fixed some of the removeLiquidity tests

  jalextowle

  committed
  d37b3de

  Copy full SHA for d37b3de

• Fixed the addLiquidity tests

  jalextowle

  committed
  b945cd0

  Copy full SHA for b945cd0

• Fixed the redeemWithdrawalShares test

  jalextowle

  committed
  7f967f2

  Copy full SHA for 7f967f2

Commits on Dec 6, 2023

• Fixed a bug in calculateDistributeExcessIdle

  jalextowle

  committed
  e06c338

  Copy full SHA for e06c338

• Fixed a bug in YieldSpaceMath's calculateMaxSellBondsIn

  jalextowle

  committed
  92ddccb

  Copy full SHA for 92ddccb

• Fixed an edge case that caused the present value to underflow

  jalextowle

  committed
  50f15c3

  Copy full SHA for 50f15c3

• Fixed a couple more failing tests

  jalextowle

  committed
  656ee6d

  Copy full SHA for 656ee6d

Commits on Dec 7, 2023

• Removed the LP fairness tests and started fixed the LP withdrawal tests

  jalextowle

  committed
  1a7f86d

  Copy full SHA for 1a7f86d

• Fixed more of the LP withdrawal tests and found a negative solvency edge case

  jalextowle

  committed
  8e08ea2

  Copy full SHA for 8e08ea2

• Fixed the remaining tests

  jalextowle

  committed
  223af66

  Copy full SHA for 223af66

Commits on Dec 8, 2023

• Improved the LP withdrawal tests and added failing edge cases

  jalextowle

  committed
  4250edc

  Copy full SHA for 4250edc

Commits on Dec 12, 2023

• Merge remote-tracking branch 'origin/main' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  9e7889e

  Copy full SHA for 9e7889e

• Fixed some edge cases in LpWithdrawalTest

  jalextowle

  committed
  25175a6

  Copy full SHA for 25175a6

• Added another edge case to the tests

  jalextowle

  committed
  f7cd4c0

  Copy full SHA for f7cd4c0

• Merge remote-tracking branch 'origin/main' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  2d14db8

  Copy full SHA for 2d14db8

• Fixed issues post-merge

  jalextowle

  committed
  e587f00

  Copy full SHA for e587f00

• Appeased the linter in YieldSpaceMath

  jalextowle

  committed
  f1673fc

  Copy full SHA for f1673fc

• Renamed LPMath to LpMath

  jalextowle

  committed
  e09f7ef

  Copy full SHA for e09f7ef

• Reverted back to using LPMath

  jalextowle

  committed
  508d0d0

  Copy full SHA for 508d0d0

• Use calculateUpdateLiquidity in _updateLiquidity

  jalextowle

  committed
  a8bf20b

  Copy full SHA for a8bf20b

• Added an edge-case to the Zombie interest tests

  jalextowle

  committed
  75c2600

  Copy full SHA for 75c2600

• Started to polish LPMath

  jalextowle

  committed
  c71a39e

  Copy full SHA for c71a39e

• Continued polishing

  jalextowle

  committed
  14b170e

  Copy full SHA for 14b170e

Commits on Dec 13, 2023

• Continued polishing

  jalextowle

  committed
  dcb53b6

  Copy full SHA for dcb53b6

• Added a parameter for the number iterations in calculateMaxShareReservesDelta

  jalextowle

  committed
  ab8a163

  Copy full SHA for ab8a163

• Fixed some of the broken tests

  jalextowle

  committed
  61a43c9

  Copy full SHA for 61a43c9

• Merge remote-tracking branch 'origin/main' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  142df7f

  Copy full SHA for 142df7f

• Added short-circuiting for calculateDistributeExcessIdleShareProceeds

  jalextowle

  committed
  0f9bd85

  Copy full SHA for 0f9bd85

• Optimized the sad-path of _distributeExcessIdle

  jalextowle

  committed
  52ca8b3

  Copy full SHA for 52ca8b3

• Fixed an edge-case in calculateNetCurveTradeSafe when we are net long

  jalextowle

  committed
  de6e176

  Copy full SHA for de6e176

Commits on Dec 14, 2023

• Bug fix that significantly improves the convergence of calculateMaxShareReservesDelta

  jalextowle

  committed
  a2d03a6

  Copy full SHA for a2d03a6

• Fixed some bugs in calculateDistributeExcessIdleShareProceeds and improved the convergence

  jalextowle

  committed
  0ccd9ae

  Copy full SHA for 0ccd9ae

• More screw tightening and bounds finding

  jalextowle

  committed
  15f9f22

  Copy full SHA for 15f9f22

• Adds a test that shows that adding liquidity fails when PV = 0

  jalextowle

  committed
  62f4cab

  Copy full SHA for 62f4cab

• Added checks to ensure that distribute excess idle works with remove liquidity in LPWithdrawalTest

  jalextowle

  committed
  e813109

  Copy full SHA for e813109

Commits on Dec 15, 2023

• Cleaned up and added tests for the share proceeds edge case calculation

  jalextowle

  committed
  3bbfaad

  Copy full SHA for 3bbfaad

• Added short-circuting and an iterations constant to calculateMaxShareReservesDelta

  jalextowle

  committed
  9869146

  Copy full SHA for 9869146

• Cleaned up the LP withdrawal tests

  jalextowle

  committed
  887ac65

  Copy full SHA for 887ac65

• Cleaned up the HyperdriveLP contract and fixed a test edge case

  jalextowle

  committed
  3bcc88e

  Copy full SHA for 3bcc88e

• Removed snake case from MockYieldSpaceMath

  jalextowle

  committed
  061f8c0

  Copy full SHA for 061f8c0

• Fixed the Rust tests

  jalextowle

  committed
  f9912d2

  Copy full SHA for f9912d2

Commits on Dec 18, 2023

• Apply suggestions from code review

  Show description for fc1c8af
  

  jalextowle

  and

  jrhea

  authored
  fc1c8af

  Copy full SHA for fc1c8af

• Addressed some review feedback from @jrhea

  jalextowle

  committed
  7a6bb14

  Copy full SHA for 7a6bb14

• Added the algorithm to the comments

  jalextowle

  committed
  7db99c8

  Copy full SHA for 7db99c8

• Merge remote-tracking branch 'origin/jalextowle/feature/distribute-excess-idle-overhaul-2' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  ee7aaae

  Copy full SHA for ee7aaae

• Cleaned up the algorithm documentation in calculateDistributeExcessIdle

  jalextowle

  committed
  b51a40f

  Copy full SHA for b51a40f

• Removed some unneeded FIXMEs

  jalextowle

  committed
  adfa445

  Copy full SHA for adfa445

• Updated calculateMaxBuyBondsOutDerivativeSafe so that it rounds consistently

  jalextowle

  committed
  6e1dce4

  Copy full SHA for 6e1dce4

• Updated calculateSharesInGivenBondsOutDerivative so that it rounds consistently

  jalextowle

  committed
  037b091

  Copy full SHA for 037b091

• Updated calculateSharesOutGivenBondsInDerivative so that it rounds consistently

  jalextowle

  committed
  37b8809

  Copy full SHA for 37b8809

• Updated calculateMaxShareReservesDeltaInitialGuess to make the rounding more consistent

  jalextowle

  committed
  4854918

  Copy full SHA for 4854918

• Updated calculateDistributeExcessIdleShareProceedsNetLongEdgeCaseSafe to make the rounding more consistent

  jalextowle

  committed
  48005a0

  Copy full SHA for 48005a0

• Updated calculateDistributeExcessIdleWithdrawalSharesRedeemed to make the rounding more consistent

  jalextowle

  committed
  ede3f93

  Copy full SHA for ede3f93

• Updated calculateDistributeExcessIdleShareProceeds to make the rounding more consistent

  jalextowle

  committed
  ef21785

  Copy full SHA for ef21785

• Fixed the remaining issues related to rounding

  jalextowle

  committed
  5f20c87

  Copy full SHA for 5f20c87

• Disabled the code-size-check

  jalextowle

  committed
  41fe4ee

  Copy full SHA for 41fe4ee

• Merge remote-tracking branch 'origin/main' into jalextowle/feature/distribute-excess-idle-overhaul-2

  jalextowle

  committed
  8319231

  Copy full SHA for 8319231