Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the sweep function and wrote some comprehensive tests #720

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

jalextowle
Copy link
Contributor

This PR removes the concept of sweepTargets from the repo and implements a balance check to make this approach safe.

@jalextowle jalextowle requested a review from jrhea January 10, 2024 02:57
Copy link

github-actions bot commented Jan 10, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 04cb6ca Previous: aadaa99 Deviation Status
addLiquidity: min 1600 gas 1600 gas 0% 🟰
addLiquidity: avg 66750 gas 55098 gas 21.1478% 🚨
addLiquidity: max 275046 gas 232446 gas 18.3268% 🚨
checkpoint: min 1172 gas 1172 gas 0% 🟰
checkpoint: avg 48038 gas 47937 gas 0.2107% 🚨
checkpoint: max 202123 gas 202123 gas 0% 🟰
closeLong: min 1580 gas 1580 gas 0% 🟰
closeLong: avg 27900 gas 26510 gas 5.2433% 🚨
closeLong: max 147816 gas 139624 gas 5.8672% 🚨
closeShort: min 1549 gas 1549 gas 0% 🟰
closeShort: avg 29995 gas 28777 gas 4.2325% 🚨
closeShort: max 147189 gas 144389 gas 1.9392% 🚨
initialize: min 1538 gas 1538 gas 0% 🟰
initialize: avg 214974 gas 181786 gas 18.2566% 🚨
initialize: max 256760 gas 256760 gas 0% 🟰
openLong: min 1509 gas 1509 gas 0% 🟰
openLong: avg 50165 gas 40502 gas 23.8581% 🚨
openLong: max 185904 gas 162207 gas 14.6091% 🚨
openShort: min 1519 gas 1519 gas 0% 🟰
openShort: avg 47392 gas 47335 gas 0.1204% 🚨
openShort: max 161536 gas 161536 gas 0% 🟰
redeemWithdrawalShares: min 1575 gas 1575 gas 0% 🟰
redeemWithdrawalShares: avg 23340 gas 18465 gas 26.4013% 🚨
redeemWithdrawalShares: max 105958 gas 84767 gas 24.9991% 🚨
removeLiquidity: min 1661 gas 1661 gas 0% 🟰
removeLiquidity: avg 148623 gas 118880 gas 25.0193% 🚨
removeLiquidity: max 323560 gas 258848 gas 25% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2024

Coverage Status

coverage: 95.238% (+0.2%) from 95.057%
when pulling 04cb6ca on jalextowle/instance/sweep-targets
into aadaa99 on main.

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jalextowle jalextowle merged commit c2e0f6c into main Jan 10, 2024
8 checks passed
@jalextowle jalextowle deleted the jalextowle/instance/sweep-targets branch January 10, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants