Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add temp fix #2557

Merged
merged 4 commits into from
Jan 22, 2025
Merged

add temp fix #2557

merged 4 commits into from
Jan 22, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jan 21, 2025 •
edited by lastmjs
Loading

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

@bdemann
Copy link
Member Author

bdemann commented Jan 22, 2025

This is a temp fix for #2496 but it doesn't robustly resolve it

@lastmjs lastmjs merged commit 151ddb5 into main Jan 22, 2025
212 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdemann @lastmjs