Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hidden methods #2565

Merged
merged 5 commits into from
Jan 24, 2025
Merged

add hidden methods #2565

merged 5 commits into from
Jan 24, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jan 23, 2025

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • All new functions have JSDoc/Rustdoc comments
  • Code tested thoroughly
  • Related issues have been linked and all tasks have been completed or made into separate issues

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues

@bdemann bdemann marked this pull request as ready for review January 23, 2025 00:05
@bdemann bdemann linked an issue Jan 23, 2025 that may be closed by this pull request
@bdemann bdemann requested a review from lastmjs January 24, 2025 20:44
@lastmjs lastmjs merged commit 351ab24 into main Jan 24, 2025
374 checks passed
@bdemann bdemann deleted the hidden branch February 7, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hidden (query and update option)
2 participants