Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto merge dependabot workflow #2589

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Add auto merge dependabot workflow #2589

merged 2 commits into from
Jan 28, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jan 27, 2025

For Reviewers

Understanding the gh docs will help, especially the bit about merging

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • This PR's name is properly capitalized, descriptive, and ready to be in the release notes

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • This PR's name is properly capitalized, descriptive, and ready to be in the release notes

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bdemann Benjamin DeMann
@bdemann bdemann marked this pull request as ready for review January 27, 2025 22:02
@bdemann bdemann linked an issue Jan 27, 2025 that may be closed by this pull request
@bdemann bdemann changed the title add auto merge dependabot workflow Add auto merge dependabot workflow Jan 27, 2025
@lastmjs lastmjs enabled auto-merge January 28, 2025 00:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lastmjs lastmjs merged commit 439aeae into main Jan 28, 2025
375 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide we we want to auto merge dependabot prs
2 participants