Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test_branch #2591

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Test_branch #2591

merged 1 commit into from
Jan 27, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jan 27, 2025

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • This PR's name is properly capitalized, descriptive, and ready to be in the release notes

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • This PR's name is properly capitalized, descriptive, and ready to be in the release notes

Sorry, something went wrong.

@bdemann bdemann marked this pull request as ready for review January 27, 2025 22:24
@bdemann bdemann changed the base branch from main to test_base January 27, 2025 22:24
@bdemann bdemann merged commit 0db45da into test_base Jan 27, 2025
310 of 312 checks passed
@bdemann bdemann deleted the test_branch branch February 7, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant