Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-merge dependabot PRs hot-fix #2598

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Auto-merge dependabot PRs hot-fix #2598

merged 1 commit into from
Jan 28, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Jan 28, 2025 •
edited by lastmjs
Loading

Contributor

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • This PR's name is properly capitalized, descriptive, and ready to be in the release notes

Reviewer

  • Breaking changes enumerated in the release issue
  • New documentation enumerated in the release issue
  • Code has been declaratized
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • All new functions have JSDoc/Rustdoc comments
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • This PR's name is properly capitalized, descriptive, and ready to be in the release notes

@bdemann bdemann added the dependencies Pull requests that update a dependency file label Jan 28, 2025
@bdemann bdemann closed this Jan 28, 2025
@bdemann bdemann reopened this Jan 28, 2025
@lastmjs lastmjs enabled auto-merge January 28, 2025 18:07
@lastmjs lastmjs changed the title Auto merge Auto-merge dependabot PRs Jan 28, 2025
@lastmjs lastmjs changed the title Auto-merge dependabot PRs Auto-merge dependabot PRs hot-fix Jan 28, 2025
@bdemann bdemann removed the dependencies Pull requests that update a dependency file label Jan 28, 2025
@lastmjs lastmjs merged commit 4c111e8 into main Jan 28, 2025
377 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdemann @lastmjs