Replace XSOAR 8 Example in Generic Webhook README (#33778)

* Replace XSOAR 8 Example in READM * Update Packs/GenericWebhook/Integrations/GenericWebhook/README.md Co-authored-by: Shahaf Ben Yakir <[email protected]> * docker and RN * port no required and credentials are required * fixed test-conf * change to mp * only on - prem --------- Co-authored-by: Shahaf Ben Yakir <[email protected]> Co-authored-by: meichler <[email protected]> Co-authored-by: Moshe Eichler <[email protected]>
demisto · Apr 24, 2024 · 8d54c49 · 8d54c49
1 parent 016e208
commit 8d54c49
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 7 deletions.
diff --git a/Packs/GenericWebhook/Integrations/GenericWebhook/GenericWebhook.py b/Packs/GenericWebhook/Integrations/GenericWebhook/GenericWebhook.py
@@ -122,7 +122,8 @@ def main() -> None:
     demisto.debug(f'Command being called is {demisto.command()}')
     try:
         try:
-            port = int(demisto.params().get('longRunningPort'))
+            if port_param := demisto.params().get('longRunningPort'):
+                port = int(port_param)
         except ValueError as e:
             raise ValueError(f'Invalid listen port - {e}')
         if demisto.command() == 'test-module':

diff --git a/Packs/GenericWebhook/Integrations/GenericWebhook/GenericWebhook.yml b/Packs/GenericWebhook/Integrations/GenericWebhook/GenericWebhook.yml
@@ -18,9 +18,10 @@ configuration:
   display: Listen Port
   name: longRunningPort
   type: 0
-  required: true
+  required: false
   section: Connect
-- display: Username
+- additionalinfo: "The username and password is required in XSOAR 8.5 and above"
+  display: Username
   name: credentials
   type: 9
   section: Connect
@@ -56,7 +57,7 @@ display: Generic Webhook
 name: Generic Webhook
 script:
   commands: []
-  dockerimage: demisto/fastapi:1.0.0.76036
+  dockerimage: demisto/fastapi:1.0.0.91751
   longRunning: true
   longRunningPort: true
   script: '-'

diff --git a/Packs/GenericWebhook/Integrations/GenericWebhook/README.md b/Packs/GenericWebhook/Integrations/GenericWebhook/README.md
@@ -24,7 +24,7 @@ The Generic Webhook integration is used to create incidents on event triggers. T
 You can now trigger the webhook URL:
 
 - For Cortex XSOAR 6.x: `<CORTEX-XSOAR-URL>/instance/execute/<INTEGRATION-INSTANCE-NAME>`. For example, `https://my.demisto.live/instance/execute/webhook`. Note that the string `instance` does not refer to the name of your XSOAR instance, but rather is part of the URL.
-- For Cortex XSOAR 8: `<ext-<CORTEX-XSOAR-URL>/xsoar/instance/execute/<INTEGRATION-INSTANCE-NAME>`. For example, <https://ext-dev-tertius.crtx.us.paloaltonetworks.com/xsoar/instance/execute/webhook1>. Note that the string `instance` does not refer to the name of your XSOAR instance, but rather is part of the URL.
+- For Cortex XSOAR 8: `<ext-<CORTEX-XSOAR-URL>/xsoar/instance/execute/<INTEGRATION-INSTANCE-NAME>`. For example, `https://ext-mytenant.crtx.us.paloaltonetworks.com/xsoar/instance/execute/my_instance_01`. Note that the string `instance` does not refer to the name of your XSOAR instance, but rather is part of the URL.
 
 If you're not invoking the integration via the server HTTPS endpoint, then you should trigger the webhook URL as follows: `<CORTEX-XSOAR-URL>:<LISTEN_PORT>/`. For example, `https://my.demisto.live:8000/`.
 

diff --git a/Packs/GenericWebhook/ReleaseNotes/1_0_29.md b/Packs/GenericWebhook/ReleaseNotes/1_0_29.md
@@ -0,0 +1,6 @@
+
+#### Integrations
+
+##### Generic Webhook
+
+Updated the Docker image to: *demisto/fastapi:1.0.0.91751*.
diff --git a/Packs/GenericWebhook/pack_metadata.json b/Packs/GenericWebhook/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "Generic Webhook",
     "description": "The Generic Webhook integration is used to create incidents on event triggers.",
     "support": "xsoar",
-    "currentVersion": "1.0.28",
+    "currentVersion": "1.0.29",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",

diff --git a/Tests/conf.json b/Tests/conf.json
@@ -3788,8 +3788,9 @@
         },
         {
             "integrations": "Generic Webhook",
+            "instance_name": "Generic Webhook XSOAR on-prem",
             "playbookID": "Generic Webhook - Test",
-            "fromversion": "5.5.0",
+            "marketplaces": "xsoar_on_prem",
             "has_api": false
         },
         {