Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new SLA OOB content: #2671

Merged
merged 62 commits into from
Jan 6, 2019
Merged

Added new SLA OOB content: #2671

merged 62 commits into from
Jan 6, 2019

Conversation

idovandijk
Copy link
Contributor

@idovandijk idovandijk commented Dec 18, 2018

Main Changes

  • Upgraded phishing layout (summary + quickview)
  • Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
  • Added a new SLA dashboard with new widgets
  • Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
  • Added 3 new scripts:
  1. A script to change remediation SLA automatically, upon change of severity of incident
  2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
  3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
  • Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
  1. Detection SLA by Status (pie)
  2. Remediation SLA by Status (pie)
  3. MTTD by Type (timeline)
  4. MTTR by Type (timeline)
  5. Mean Time to Detection (counter)
  6. Mean Time to Resolution (counter)

Related Issues

fixes: https://github.com/demisto/etc/issues/14090

Description

Added new OOB SLA features

Screenshots

image

image

Required version of Demisto

3.5 only for MTTR by Type widget (MTTR already existed)
4.1.0 for everything else

Does it break backward compatibility?

  • No

Additional changes

After discussing some of the requirements we have reached conclusions:

  • Time to Assignment is not presented in phishing layout by default
  • 3 Scripts were created, though not necessarily the scripts that were discussed in the beginning
  • Scripts can, but will not be triggered automatically upon field changes / breaches. Customers will have to choose the script that will run on field change (scripts are tagged to make it easier to find)
  • Widgets are a bit different than those discussed in the beginning. Additional widgets were added on top of the ones discussed in the beginning

- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
@Itay4
Copy link
Contributor

Itay4 commented Dec 18, 2018

best practise is to use fromversion: 4.1.0

idovandijk and others added 22 commits December 18, 2018 16:04
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
- Upgraded phishing layout (summary + quickview)
- Added 3 new fields: Detection SLA, Remediation SLA and Time to Assignment
- Added a new SLA dashboard with new widgets
- Upgraded Phishing Investigation - Generic playbook - now utilizes new SLA features
- Added 3 new scripts:
1. A script to change remediation SLA automatically, upon change of severity of incident
2. A script that sends an Email of SLA breach, which can be set to run upon SLA breach
3. A script to change the Time to Assignment field (new field) upon owner change (from empty owner to some new owner)
- Added 5 new widgets of many different types, which will be presented in new SLA dashboard:
 1. Detection SLA by Status (pie)
 2. Remediation SLA by Status (pie)
 3. MTTD by Type (timeline)
 4. MTTR by Type (timeline)
 5. Mean Time to Detection (counter)
 6. Mean Time to Resolution (counter)
@glicht glicht requested a review from ronykoz December 20, 2018 09:13
@glicht
Copy link
Contributor

glicht commented Dec 20, 2018

@idovandijk I am ok with the description fixes.

I have an issue with the incident types. I did a load of the content released from circleci and i am not seeing the new incident types.

Can you test this out.

@idovandijk
Copy link
Contributor Author

I tested on both 4.0 and 4.1 successfully. No bugs so far.
4.0 shows no 4.1 content. Failing tests are not mine. Playbook runs well on 4.1 and so do the rest of the features.

Injecting to trigger timetoassignment script:
image

Injecting to trigger remediationsla script:
image

Dashboards (now stretched out as requested):
image

Layouts:
image

image

I think we can merge now :)

@ronykoz
Copy link
Contributor

ronykoz commented Jan 2, 2019

@idovandijk why there are so many changes in the id_set.json file?

@idovandijk
Copy link
Contributor Author

@idovandijk why there are so many changes in the id_set.json file?

It's only what we changed together. Maybe the order of the fields? Remember they kept changing order on my pc

@ronykoz
Copy link
Contributor

ronykoz commented Jan 2, 2019

@idovandijk why there are so many changes in the id_set.json file?

It's only what we changed together. Maybe the order of the fields? Remember they kept changing order on my pc

seems that you are not pulled from master, could you try to pull from master and see what happens?

@idovandijk
Copy link
Contributor Author

@ronykoz can you approve this PR so Anar will merge?

# Conflicts:
#	Tests/id_set.json
@anara123 anara123 merged commit 0a79805 into master Jan 6, 2019
@anara123 anara123 deleted the sla-oob-content branch January 6, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants