Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription notification. #34023

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix subscription notification. #34023

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39abbb9
Fix subscription notification.
thefrieddan1 Apr 17, 2024
adc5d83
Update Packs/AWS-SNS-Listener/ReleaseNotes/1_0_1.md
thefrieddan1 Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Packs/AWS-SNS-Listener/Integrations/AWSSNSListener/AWSSNSListener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def is_valid_integration_credentials(credentials, request_headers, token):
def handle_subscription_confirmation(subscribe_url) -> Response: # pragma: no cover
demisto.debug('SubscriptionConfirmation request')
try:
return client.get(full_url=subscribe_url)
return client.get(full_url=subscribe_url, resp_type='response')
except Exception as e:
demisto.error(f'Failed handling SubscriptionConfirmation: {e}')
return Response(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
Expand Down Expand Up @@ -208,7 +208,7 @@ async def handle_post(request: Request,
demisto.error(f'Error in request parsing: {e}')
return Response(status_code=status.HTTP_400_BAD_REQUEST, content='Failed parsing request.')
if not is_valid_sns_message(payload):
return 'Validation of SNS message failed.'
return Response(status_code=status.HTTP_401_UNAUTHORIZED, content='Validation of SNS message failed.')

if type == 'SubscriptionConfirmation':
demisto.debug('SubscriptionConfirmation request')
Expand Down
2 changes: 1 addition & 1 deletion Packs/AWS-SNS-Listener/Integrations/AWSSNSListener/AWSSNSListener.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ display: AWS-SNS-Listener
name: AWS-SNS-Listener
script:
commands: []
dockerimage: demisto/fastapi:1.0.0.87576
dockerimage: demisto/fastapi:1.0.0.91751
longRunning: true
longRunningPort: true
script: '-'
Expand Down
6 changes: 6 additions & 0 deletions Packs/AWS-SNS-Listener/ReleaseNotes/1_0_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#### Integrations

##### AWS-SNS-Listener

- Fixed an issue with confirm Subscription notification.
thefrieddan1 marked this conversation as resolved.
Show resolved Hide resolved
- Updated the Docker image to: *demisto/fastapi:1.0.0.91751*.
2 changes: 1 addition & 1 deletion Packs/AWS-SNS-Listener/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "AWS-SNS-Listener",
"description": "A long running AWS SNS Listener service that can subscribe to an SNS topic and create incidents from the messages received.",
"support": "xsoar",
"currentVersion": "1.0.0",
"currentVersion": "1.0.1",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
Loading