[Format --deprecated] Deprecated Beta Integration (#4332)

* fix * RN * Update .changelog/4332.yml * pre-commit * Apply suggestions from code review Co-authored-by: dorschw <[email protected]> * typing --------- Co-authored-by: dorschw <[email protected]>
demisto · Jun 10, 2024 · f7db5ed · f7db5ed
1 parent b52c2ae
commit f7db5ed
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/.changelog/4332.yml b/.changelog/4332.yml
@@ -0,0 +1,4 @@
+changes:
+- description: Fixed an issue using the **format** command with the **--deprecate** flag would not properly work on beta integrations.
+  type: fix
+pr_number: 4332
diff --git a/demisto_sdk/commands/format/tests/test_formatting_yml_test.py b/demisto_sdk/commands/format/tests/test_formatting_yml_test.py
@@ -9,12 +9,15 @@
 
 import pytest
 import requests_mock
+from pytest_mock import MockerFixture
 
 from demisto_sdk.commands.common.constants import (
     ALERT_FETCH_REQUIRED_PARAMS,
+    BETA_INTEGRATION,
     FEED_REQUIRED_PARAMS,
     GENERAL_DEFAULT_FROMVERSION,
     INCIDENT_FETCH_REQUIRED_PARAMS,
+    INTEGRATION,
     NO_TESTS_DEPRECATED,
     MarketplaceVersions,
 )
@@ -1441,6 +1444,7 @@ def test_set_fromversion_six_new_contributor_pack(self, pack):
             bs.set_fromVersion()
             assert bs.data["fromversion"] == GENERAL_DEFAULT_FROMVERSION, path
 
+    @pytest.mark.parametrize("file_type", [INTEGRATION, BETA_INTEGRATION])
     @pytest.mark.parametrize(
         "user_input, description_result",
         [
@@ -1449,7 +1453,13 @@ def test_set_fromversion_six_new_contributor_pack(self, pack):
         ],
     )
     def test_update_deprecate_in_integration(
-        self, pack, mocker, monkeypatch, user_input, description_result
+        self,
+        pack: Pack,
+        mocker: MockerFixture,
+        monkeypatch: pytest.MonkeyPatch,
+        user_input: str,
+        description_result: str,
+        file_type: str,
     ):
         """
         Given
@@ -1465,7 +1475,7 @@ def test_update_deprecate_in_integration(
             BaseUpdateYML, "get_id_and_version_path_object", return_value={}
         )
         base_update_yml = BaseUpdateYML(input=integration.yml.path, deprecate=True)
-        base_update_yml.update_deprecate(file_type="integration")
+        base_update_yml.update_deprecate(file_type=file_type)
 
         assert base_update_yml.data["deprecated"]
         assert base_update_yml.data["tests"] == [NO_TESTS_DEPRECATED]

diff --git a/demisto_sdk/commands/format/update_generic_yml.py b/demisto_sdk/commands/format/update_generic_yml.py
@@ -5,6 +5,7 @@
 import click
 
 from demisto_sdk.commands.common.constants import (
+    BETA_INTEGRATION,
     ENTITY_TYPE_TO_DIR,
     FILETYPE_TO_DEFAULT_FROMVERSION,
     INTEGRATION,
@@ -366,10 +367,15 @@ def update_deprecate(self, file_type=None):
 
         self.data["deprecated"] = True
 
-        if self.data.get("tests") or file_type in (INTEGRATION, PLAYBOOK, SCRIPT):
+        if self.data.get("tests") or file_type in (
+            INTEGRATION,
+            BETA_INTEGRATION,
+            PLAYBOOK,
+            SCRIPT,
+        ):
             self.data["tests"] = [NO_TESTS_DEPRECATED]
 
-        if file_type in [INTEGRATION, PLAYBOOK]:
+        if file_type in (INTEGRATION, BETA_INTEGRATION, PLAYBOOK):
 
             description_field = "description"