Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements to pipfile #1497

Merged
merged 58 commits into from
Aug 8, 2021
Merged

Requirements to pipfile #1497

merged 58 commits into from
Aug 8, 2021

Conversation

tomneeman151293
Copy link
Contributor

@tomneeman151293 tomneeman151293 commented Jul 25, 2021

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://github.com/demisto/etc/issues/39231

@jochman jochman force-pushed the Requirements-To-Pipfiles branch 5 times, most recently from 9087a34 to 8b893ad Compare July 25, 2021 13:51
@jochman jochman force-pushed the Requirements-To-Pipfiles branch from 8b893ad to 2e7301c Compare July 26, 2021 05:30
Copy link
Contributor

@jochman jochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good overall, see the comments. 🤷‍♀️

.circleci/config.yml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 1 alert when merging f99148e into 2e263e9 - view on LGTM.com

new alerts:

  • 1 for Unused import

@tomneeman151293 tomneeman151293 requested a review from jochman August 3, 2021 10:44
@tomneeman151293
Copy link
Contributor Author

@jochman Fixes done

@jochman
Copy link
Contributor

jochman commented Aug 3, 2021

@jochman Fixes done

Please just check if nightly on content/upload flow is fine with the changes.

@tomneeman151293 tomneeman151293 force-pushed the Requirements-To-Pipfiles branch from 3e32223 to 4b44324 Compare August 3, 2021 12:03
Copy link
Contributor

@jochman jochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@tomneeman151293 tomneeman151293 merged commit 822a73a into master Aug 8, 2021
@tomneeman151293 tomneeman151293 deleted the Requirements-To-Pipfiles branch August 8, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants