Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pycln in repos with hypen in their name #3998

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Fix Pycln in repos with hypen in their name #3998

merged 5 commits into from
Feb 7, 2024

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Jan 30, 2024

Fixing an issue where the pycln hook won't work in a repo when the repo name contains a hypen (-)

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9601

@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 221b14ca-84a8-40ba-9fb0-dc7ce900d1ce

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8034 unchanged lines in 294 files lost coverage.
  • Overall coverage decreased (-18.1%) to 80.817%

Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/clients/configs.py 1 97.14%
demisto_sdk/commands/common/content/objects/pack_objects/incident_field/incident_field.py 1 65.0%
demisto_sdk/commands/common/content/objects/pack_objects/job/job.py 1 83.33%
demisto_sdk/commands/common/content/objects/pack_objects/lists/lists.py 1 85.71%
demisto_sdk/commands/common/files/errors.py 1 71.43%
demisto_sdk/commands/common/files/text_file.py 1 78.13%
demisto_sdk/commands/common/hook_validations/deprecation.py 1 98.72%
demisto_sdk/commands/common/hook_validations/job.py 1 98.41%
demisto_sdk/commands/common/hook_validations/layout_rule.py 1 88.89%
demisto_sdk/commands/common/hook_validations/lists.py 1 96.55%
Totals Coverage Status
Change from base Build 7724927093: -18.1%
Covered Lines: 36321
Relevant Lines: 44942

💛 - Coveralls

.changelog/3998.yml Outdated Show resolved Hide resolved
@dorschw dorschw changed the title Fix Pycln Fix Pycln in repos with hypen in their name Feb 7, 2024
@dorschw dorschw merged commit 95c3363 into master Feb 7, 2024
33 checks passed
@dorschw dorschw deleted the ds-pycln-fix branch February 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants