Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where upload failed when trying to upload a content item that was missing a description or type field/ XSUP-33213 #4020

Merged

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Feb 6, 2024

Related Issues

relates: https://jira-dc.paloaltonetworks.com/browse/XSUP-33213

Description

Fixed an issue where upload failed when trying to upload a content item that was missing a description or type field, by giving those fields a default value.

@RosenbergYehuda RosenbergYehuda self-assigned this Feb 6, 2024
@RosenbergYehuda RosenbergYehuda marked this pull request as draft February 6, 2024 14:13
@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2024

Pull Request Test Coverage Report for Build 7831941207

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+11.2%) to 92.07%

Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/neo4j_service.py 3 95.92%
demisto_sdk/commands/content_graph/commands/common.py 5 58.82%
Totals Coverage Status
Change from base Build 7991dec4-65a9-4f8d-990e-b28c3fccab68: 11.2%
Covered Lines: 56806
Relevant Lines: 61699

💛 - Coveralls

@RosenbergYehuda RosenbergYehuda marked this pull request as ready for review February 8, 2024 09:24
@RosenbergYehuda RosenbergYehuda changed the title init Fixed an issue where upload failed when trying to upload a content item that was missing a description or type field/ XSUP-33213 Feb 8, 2024
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilaner @RosenbergYehuda can we upload a content-item without description or type?

Is it a requirement for upload or not? (meaning without those fields, its impossible to upload)

Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

.changelog/4020.yml Outdated Show resolved Hide resolved
@RosenbergYehuda RosenbergYehuda merged commit e4c3770 into master Feb 8, 2024
33 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR/Fix-by-changing-description-to-be-optinal branch February 8, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants