-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom conatiner registry #4039
Conversation
Pull Request Test Coverage Report for Build 8232728890Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…True if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good,
see my comment and add unit test for the configuration.
README.md
Outdated
## Custom Container Registry | ||
|
||
By default, the `demisto-sdk` will use `dockerhub` as the container registry to pull the integrations and scripts docker image. | ||
It is possible to provide a different container registry. In order to configure it, the following environment variables must be set: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to provide a different container registry. In order to configure it, the following environment variables must be set: | |
In order configure a custom container registry, the following environment variables must be set: |
Changelog(s) in markdown:
|
Adds support for custom container registery. If a different container registry than dockerhub is configured, it will try to login and will skip the queries to dockerhub api for the python versions.
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-33373?filter=-1
Description