Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom conatiner registry #4039

Merged
merged 22 commits into from
Mar 11, 2024
Merged

Support custom conatiner registry #4039

merged 22 commits into from
Mar 11, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Feb 12, 2024

Adds support for custom container registery. If a different container registry than dockerhub is configured, it will try to login and will skip the queries to dockerhub api for the python versions.

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-33373?filter=-1

Description

@coveralls
Copy link
Collaborator

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 8232728890

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 36 (91.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+11.6%) to 92.221%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/common/docker_helper.py 29 32 90.63%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/common/docker_helper.py 2 96.7%
Totals Coverage Status
Change from base Build 78164df6-2c0e-4d10-81ab-aac078db7ce7: 11.6%
Covered Lines: 59135
Relevant Lines: 64123

💛 - Coveralls

Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good,
see my comment and add unit test for the configuration.

README.md Outdated
## Custom Container Registry

By default, the `demisto-sdk` will use `dockerhub` as the container registry to pull the integrations and scripts docker image.
It is possible to provide a different container registry. In order to configure it, the following environment variables must be set:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is possible to provide a different container registry. In order to configure it, the following environment variables must be set:
In order configure a custom container registry, the following environment variables must be set:

@JudahSchwartz JudahSchwartz removed their request for review February 14, 2024 10:05
Copy link

Changelog(s) in markdown:

  • Fixed an issue in lint and pre-commit with custom container registry #4039

@ilaner ilaner merged commit 53a7682 into master Mar 11, 2024
34 checks passed
@ilaner ilaner deleted the use_docker_io branch March 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants