Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get property in pre-commit #4238

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix get property in pre-commit #4238

merged 3 commits into from
Apr 24, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Apr 17, 2024

The get_property didn't work corrrectly in this use case:

property: true
property:<mode>: false

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • fixed an issue where reading pre-commit config templates would not handle cases with key=false and key:mode=true. #4238

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • fixed an issue where reading pre-commit config templates would not handle cases with key=false and key:mode=true. #4238

@dorschw dorschw merged commit d6c4740 into master Apr 24, 2024
24 checks passed
@dorschw dorschw deleted the fix_pre_commit_override_get_property branch April 24, 2024 07:53
This was referenced May 5, 2024
Draft
Draft
Draft
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilaner @dorschw