Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for auto update docker image field #4287

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Added fix for auto update docker image field #4287

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9e3cc0
Added fix
anas-yousef May 20, 2024
3104a88
Added chagelog
anas-yousef May 20, 2024
4857e29
Merge branch 'master' of github.com:demisto/demisto-sdk into ay-auto-…
anas-yousef Jun 19, 2024
8be7486
Added default value and updated UT
anas-yousef Jun 19, 2024
2ebf09d
Added new line
anas-yousef Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/4287.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- description: Added a fix where the `auto_update_docker_image` field was not updated correctly in the the content-graph.
type: fix
pr_number: 4287
2 changes: 1 addition & 1 deletion demisto_sdk/commands/content_graph/parsers/integration_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,4 @@ def subtype(self):
def auto_update_docker_image(self):
return (
get_value(self.yml_data, "autoUpdateDockerImage", "")
).lower() != "false"
).lower() not in ("false", False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a test that a yml provided with no input at all defaults to auto_update_docker_image = True

Loading