-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit] Ignore docker_native_image_config.json in simple repo #4314
[pre-commit] Ignore docker_native_image_config.json in simple repo #4314
Conversation
Changelog(s) in markdown:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt seem like the right solution to me. We shouldnt distinguish based on internal vs external repo. If an external repo wants to run on the native image they should be allowed to. Lets instead lazy load this tag, that we should only need it if native image is declated in the precommit file
…e_docker_native_image_config.json_in_simple_repo
@JudahSchwartz I have made the change, if you could please look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing
Description
Ignore
docker_native_image_config.json
in simple repo.To avoid the following error: