Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mr106 validation refactor #4372

Merged
merged 27 commits into from
Jun 26, 2024
Merged

Mr106 validation refactor #4372

merged 27 commits into from
Jun 26, 2024

Conversation

maimorag
Copy link
Contributor

Related Issues

fixes: MR106

Description

@maimorag maimorag marked this pull request as ready for review June 24, 2024 15:15
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Converted MR106 validation to new validation format. The validation verifies the types in schema files. #4372

YuvHayun
YuvHayun approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Minor comments.

demisto_sdk/commands/validate/validators/MR_validators/MR106_modeling_rule_scheme_types.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/MR_validators/MR106_modeling_rule_scheme_types.py Outdated Show resolved Hide resolved
maimorag and others added 2 commits June 25, 2024 12:56
@maimorag maimorag requested review from YuvHayun and dantavori June 25, 2024 10:03
dantavori
dantavori reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, see notes

demisto_sdk/commands/validate/validators/MR_validators/MR106_modeling_rule_scheme_types.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/MR_validators/MR106_modeling_rule_scheme_types.py Outdated Show resolved Hide resolved
.changelog/4372.yml Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/MR_validators/MR106_modeling_rule_scheme_types.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/MR_validators/MR106_modeling_rule_scheme_types.py Outdated Show resolved Hide resolved
demisto_sdk/commands/content_graph/parsers/related_files.py Outdated Show resolved Hide resolved
demisto_sdk/commands/content_graph/parsers/related_files.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Converted MR106 validation to new validation format. The validation verifies the types in schema files of modeling rules. #4372

@maimorag maimorag requested a review from dantavori June 26, 2024 08:34
@maimorag maimorag merged commit d471c44 into master Jun 26, 2024
25 checks passed
@maimorag maimorag deleted the MR106-validation-refactor branch June 26, 2024 10:29
@samuelFain samuelFain mentioned this pull request Jun 30, 2024
Merged
@content-bot content-bot mentioned this pull request Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantavori dantavori dantavori approved these changes

@YuvHayun YuvHayun Awaiting requested review from YuvHayun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maimorag @dantavori @YuvHayun