Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pre Commit] mypy in docker #4468

Merged
merged 36 commits into from
Sep 19, 2024
Merged

[Pre Commit] mypy in docker #4468

merged 36 commits into from
Sep 19, 2024

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Jul 30, 2024 •
edited
Loading

@shmuel44 shmuel44 mentioned this pull request Aug 14, 2024
Merged
@shmuel44 shmuel44 self-assigned this Aug 14, 2024
@shmuel44 shmuel44 requested a review from dorschw August 14, 2024 13:59
@shmuel44 shmuel44 marked this pull request as ready for review September 8, 2024 05:22
dorschw
dorschw reviewed Sep 8, 2024
View reviewed changes
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

demisto_sdk/commands/lint/resources/python3_requirements/dev-requirements.txt Outdated Show resolved Hide resolved
demisto_sdk/commands/common/docker_helper.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/common/docker_helper.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/tests/pre_commit_test.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Modified the mypy pre-commit hook in the pre-commit command which would previously run locally. The hook now runs in Docker and is renamed to mypy-in-docker, ensuring. #4468

dorschw
dorschw reviewed Sep 18, 2024
View reviewed changes
demisto_sdk/commands/pre_commit/hooks/docker.py Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/docker.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/hooks/mypy.py Outdated Show resolved Hide resolved
demisto_sdk/commands/pre_commit/pre_commit_command.py Outdated Show resolved Hide resolved
@shmuel44 shmuel44 requested a review from dorschw September 19, 2024 10:26
shmuel44
shmuel44 commented Sep 19, 2024
View reviewed changes
.changelog/4468.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Modified the mypy pre-commit hook in the pre-commit command which would previously run locally. The hook now runs in Docker and is renamed to mypy-in-docker. #4468

@shmuel44 shmuel44 merged commit 5d8bb75 into master Sep 19, 2024
22 checks passed
@shmuel44 shmuel44 deleted the sk_mypy_in_docker branch September 19, 2024 13:27
@RosenbergYehuda RosenbergYehuda mentioned this pull request Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

Assignees

@shmuel44 shmuel44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shmuel44 @dorschw