Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main to typer #4637

Merged
merged 51 commits into from
Nov 25, 2024
Merged

Main to typer #4637

merged 51 commits into from
Nov 25, 2024

Conversation

Shellyber
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12076

Description

  • Split the main
  • Convert it to use the Typer package
  • Added _setup.py file for each command, including the command execution and options.

@Shellyber Shellyber marked this pull request as ready for review November 10, 2024 18:06
@Shellyber
Copy link
Contributor Author

@ShahafBenYakir @samuelFain Ran a nightly SDK build
All relevant tests passed. I fixed the failed id-set, and the end2end test the failed is not related to my PR. We're dealing with it in the on-call.
Everything looks fine - please approve

@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • The Demisto-SDK CLI has been upgraded to use Typer for command-line interface (CLI) management. #4637

ShahafBenYakir
ShahafBenYakir approved these changes Nov 24, 2024
View reviewed changes
.github/workflows/on-push.yml Outdated Show resolved Hide resolved
@Shellyber Shellyber merged commit 2e68f31 into master Nov 25, 2024
25 checks passed
@Shellyber Shellyber deleted the main-to-typer branch November 25, 2024 08:55
@shmuel44 shmuel44 mentioned this pull request Nov 28, 2024
Merged
This was referenced Dec 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

@samuelFain samuelFain Awaiting requested review from samuelFain samuelFain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shellyber @ShahafBenYakir @YuvHayun