Ciac 11100 playbook run in build #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of github.com:demisto/demisto-sdk into CIAC-11868-adding-fixtures-and-abilities-to-flow-tests
… of github.com:demisto/demisto-sdk into CIAC-11100-playbook-run-in-build
…00-playbook-run-in-build
dantavori
requested changes
Jan 5, 2025
demisto_sdk/commands/test_content/test_use_case/test_use_case.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/test_content/test_use_case/test_use_case.py
Outdated
Show resolved
Hide resolved
Comment on lines
+367
to
+369
| except Exception: | ||
| self.build_context.logging_module.exception("~~ Thread failed ~~") | ||
| self.build_context.tests_data_keeper.errors = True |
There was a problem hiding this comment.
how does it behave in case of exception?
- will the rest of the threads continue?
- will we see the error message?
There was a problem hiding this comment.
yes, each thread should run its tests, the rest of the threads should keep running.
Also logs per thread are printed (with thread number)
There was a problem hiding this comment.
can we have one sanity E2E test (from the main command method)?
There was a problem hiding this comment.
Not sure its needed, the methods are tested in unit tests.
Shellyber
reviewed
Jan 6, 2025
Co-authored-by: Dan Tavori <[email protected]>
…/demisto-sdk into CIAC-11100-playbook-run-in-build
…00-playbook-run-in-build
…00-playbook-run-in-build :wq! :q :q! :wq! 1#
kobymeir
requested changes
Jan 17, 2025
demisto_sdk/commands/test_content/test_use_case/template_file.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/test_content/test_use_case/template_file.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/test_content/test_use_case/template_file.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/test_content/test_use_case/template_file.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/test_content/test_use_case/test_use_case.py
Outdated
Show resolved
Hide resolved
dantavori
approved these changes
Jan 26, 2025
…00-playbook-run-in-build
kobymeir
approved these changes
Jan 27, 2025
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test-use-case command, to run use case flows on cloud machines.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11867