Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration command name and script name validation #4722

Merged
merged 13 commits into from
Dec 30, 2024
Merged

Add integration command name and script name validation #4722

merged 13 commits into from
Dec 30, 2024

Conversation

kamalq97
Copy link
Contributor

@kamalq97 kamalq97 commented Dec 19, 2024 •
edited
Loading

Related Issues

fixes: link to Jira issue

Description

Add validation to ensure command name in integrations and scripts does not begin with a digit.

@kamalq97 kamalq97 self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Added new BA128 validation which check names if command names start with a digit. #4722

@kamalq97 kamalq97 changed the title Add command name validation [DRAFT] Add integration command name and script name validation Dec 19, 2024
@kamalq97 kamalq97 requested a review from shmuel44 December 19, 2024 15:21
@kamalq97 kamalq97 added the python Pull requests that update Python code label Dec 19, 2024
@kamalq97 kamalq97 marked this pull request as ready for review December 26, 2024 13:21
@kamalq97 kamalq97 requested a review from dorschw December 26, 2024 13:23
YuvHayun
YuvHayun requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
minor comments.

.changelog/4722.yml Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/sdk_validation_config.toml Show resolved Hide resolved
...mands/validate/validators/BA_validators/BA128_is_command_or_script_name_starts_with_digit.py Outdated Show resolved Hide resolved
...mands/validate/validators/BA_validators/BA128_is_command_or_script_name_starts_with_digit.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/BA_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/BA_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/BA_validators_test.py Outdated Show resolved Hide resolved
YuvHayun
YuvHayun approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JasBeilin JasBeilin self-requested a review December 29, 2024 14:34
JasBeilin
JasBeilin approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kamalq97 kamalq97 merged commit 73dcc33 into master Dec 30, 2024
22 checks passed
@kamalq97 kamalq97 deleted the add-command-name-validation branch December 30, 2024 10:08
This was referenced Jan 1, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

@JasBeilin JasBeilin JasBeilin approved these changes

Assignees

@kamalq97 kamalq97

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamalq97 @YuvHayun @JasBeilin