Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed PB130 PB131 validtions #4793

Merged
merged 9 commits into from
Feb 12, 2025
Merged

fixed PB130 PB131 validtions #4793

merged 9 commits into from
Feb 12, 2025

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Feb 2, 2025

Related Issues

fixes:

Description

PB130: removed Triggers from validation.
PB131: changed to use the graph because the related items are not always available in the content item object.

Copy link

Changelog(s) in markdown:

  • Fixed an issue where PB130 was running on unnecessary files, and PB131 was not validating correctly in certain cases. #4793

@moishce moishce requested a review from YuvHayun February 12, 2025 06:01
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved with minor comments.
Also, let's make sure to move the error_codes from warning to select in the sdk_validation_config file.

.changelog/4793.yml Outdated Show resolved Hide resolved
Copy link

Changelog(s) in markdown:

  • Fixed an issue where PB130 was running on unnecessary files, and PB131 was not validating correctly in certain cases. #4793
  • Fixed an issue where PB131 was not validating correctly in certain cases. #4793

Copy link

Changelog(s) in markdown:

  • Fixed an issue where PB130 was running on unnecessary files. #4793
  • Fixed an issue where PB131 was not validating correctly in certain cases. #4793

@moishce moishce merged commit 5b90560 into master Feb 12, 2025
25 checks passed
@moishce moishce deleted the fix-pb130-pb131 branch February 12, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants