Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "replace_marketplace_references" regex / CIAC-12759 #4798

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Feb 4, 2025

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12759
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-10198

Description

  • Updated the regex for replacing incorrect marketplace versions to remove the entire version following "XSOAR."

    For example:
    "Cortex XSOAR V6.5.3 example" → "Cortex example"

  • Additionally, added an exception to preserve references that point to unique documentation specific to a product/version—no replacement occurs in such cases.

@RosenbergYehuda RosenbergYehuda changed the title YR-Fix-the-replace_marketplace_references-regex-CIAC-12759 Fix the "replace_marketplace_references" regex / CIAC-12759 Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Changelog(s) in markdown:

  • Updated regex in prepare_content to remove XSOAR versions, except in unique documentation references. #4798

Copy link

github-actions bot commented Feb 4, 2025

Changelog(s) in markdown:

  • Updated regex in demisto-sdk prepare-content command to remove XSOAR unrelated version references, except in unique documentation cases. #4798

@RosenbergYehuda RosenbergYehuda marked this pull request as ready for review February 5, 2025 08:08
@RosenbergYehuda RosenbergYehuda self-assigned this Feb 5, 2025
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work.

@RosenbergYehuda RosenbergYehuda merged commit 9816bf8 into master Feb 9, 2025
25 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR-Fix-the-replace_marketplace_references-regex-CIAC-12759 branch February 9, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants