Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added script id to schema #4805

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

added script id to schema #4805

wants to merge 5 commits into from
+7 −0

Conversation

yedidyacohenpalo
Copy link
Contributor

Related Issues

fixes: XSUP-46431

Description

Add a script ID to the pre-process schema to ensure it is not deleted when running the format.

@yedidyacohenpalo yedidyacohenpalo self-assigned this Feb 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

Changelog(s) in markdown:

  • Fixed an issue where running "Format" on a pre-processing rule would delete the script ID field, it is now retained. #4805

jbabazadeh
jbabazadeh approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbabazadeh jbabazadeh jbabazadeh approved these changes

@israelpoli israelpoli Awaiting requested review from israelpoli

Assignees

@yedidyacohenpalo yedidyacohenpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yedidyacohenpalo @jbabazadeh