fix(fs.scandir): TypeError by avoiding overwriting readonly propertie…

…s in DirentFromStat. Closes nodelib#110
demonicattack · Oct 19, 2024 · fcee619 · fcee619
1 parent 9bde8b8
commit fcee619
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/fs/fs.scandir/src/utils/fs.ts b/packages/fs/fs.scandir/src/utils/fs.ts
@@ -27,11 +27,13 @@ export class DirentFromStats extends fs.Dirent {
 for (const key of Reflect.ownKeys(fs.Dirent.prototype)) {
 	const name = key as DirentStatsKeysIntersection | 'constructor';
 
-	if (name === 'constructor') {
+	const descriptor = Object.getOwnPropertyDescriptor(fs.Dirent.prototype, name);
+
+	if (descriptor && (!(descriptor.writable ?? false) && !descriptor.set)) {
 		continue;
 	}
 
-	DirentFromStats.prototype[name] = function () {
-		return this[kStats][name]();
+	DirentFromStats.prototype[name] = function <T>(): T {
+		return this[kStats][name]() as T;
 	};
 }