Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TaskResult.Tests into FsToolkit.ErrorHandling.Tests #314

Merged

Conversation

tw0po1nt
Copy link
Contributor

@tw0po1nt tw0po1nt commented Mar 3, 2025

Proposed Changes

The FsToolkit.ErrorHandling.TaskResult project got rolled into the main project, but the same was not true for its test project. This PR does that.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

…ndling.Tests

Merge FsToolkit.ErrorHandling.TaskResult.Tests into FsToolkit.ErrorHandling.Tests

Merge FsToolkit.ErrorHandling.TaskResult.Tests into FsToolkit.ErrorHandling.Tests
@tw0po1nt
Copy link
Contributor Author

tw0po1nt commented Mar 3, 2025

Looks like I also haven't sorted all the Fable issues you said would happen @TheAngryByrd 🙂

Copy link
Contributor Author

@tw0po1nt tw0po1nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review completed

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Though I found something odd.

Master currently has:
Passed! - Failed: 0, Passed: 380, Skipped: 0, Total: 380, Duration: 1 s - FsToolkit.ErrorHandling.TaskResult.Tests.dll (net8.0)
Passed! - Failed: 0, Passed: 820, Skipped: 4, Total: 824, Duration: 2 s - FsToolkit.ErrorHandling.Tests.dll (net8.0)

Which totals to 1200 tests. However this PR's CI here reports:

Passed! - Failed: 0, Passed: 1153, Skipped: 4, Total: 1157, Duration: 3 s - FsToolkit.ErrorHandling.Tests.dll (net8.0)

There seems to be some tests missing here. Would you mind finding out why?

@tw0po1nt
Copy link
Contributor Author

tw0po1nt commented Mar 5, 2025

Ah, looks like I missed a few lists of tests within the TaskResult module. Those have been restored. Though I do think it's interesting that the main project uses manual test lists like that while the "old" TaskResult test project used the [<Tests>] annotation. Seems like it might be a good idea to switch to using [<Tests>] everywhere.

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@TheAngryByrd TheAngryByrd merged commit 6fef0ed into demystifyfp:master Mar 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants