-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge TaskResult.Tests into FsToolkit.ErrorHandling.Tests #314
Merge TaskResult.Tests into FsToolkit.ErrorHandling.Tests #314
Conversation
…ndling.Tests Merge FsToolkit.ErrorHandling.TaskResult.Tests into FsToolkit.ErrorHandling.Tests Merge FsToolkit.ErrorHandling.TaskResult.Tests into FsToolkit.ErrorHandling.Tests
Looks like I also haven't sorted all the Fable issues you said would happen @TheAngryByrd 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-review completed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Though I found something odd.
Master currently has:
Passed! - Failed: 0, Passed: 380, Skipped: 0, Total: 380, Duration: 1 s - FsToolkit.ErrorHandling.TaskResult.Tests.dll (net8.0)
Passed! - Failed: 0, Passed: 820, Skipped: 4, Total: 824, Duration: 2 s - FsToolkit.ErrorHandling.Tests.dll (net8.0)
Which totals to 1200 tests
. However this PR's CI here reports:
Passed! - Failed: 0, Passed: 1153, Skipped: 4, Total: 1157, Duration: 3 s - FsToolkit.ErrorHandling.Tests.dll (net8.0)
There seems to be some tests missing here. Would you mind finding out why?
Ah, looks like I missed a few lists of tests within the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Proposed Changes
The
FsToolkit.ErrorHandling.TaskResult
project got rolled into the main project, but the same was not true for its test project. This PR does that.Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Checklist