TypeScript Declarations #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dengelke - Whenever you have few minutes... :) |
|
Thanks @pvoisin will give it a look! |
dengelke
reviewed
May 9, 2022
lib/record.js
Outdated
| @@ -8,11 +8,12 @@ function Record(record) { | |||
|
|
|||
| Record.prototype = { | |||
| get: function (type) { | |||
| return this._record.get(type); | |||
| return this._record?.get(type); | |||
There was a problem hiding this comment.
I think this syntax breaks older versions of node.js, see failing tests
There was a problem hiding this comment.
Ah, snap! Let me change this to something backward-compatible then...
There was a problem hiding this comment.
I just remade the commit - hopefully it works now!
There was a problem hiding this comment.
Looks good! Thanks for resolving
pvoisin
force-pushed
the
feature/typescript-support
branch
from
e27d9ad to
922e25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an attempt to ship TypeScript declarations with the module so it can be used in TypeScript projects.
Also, while trying out existing code and browsing the source files I found little issues that I've fixed.