Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #72 added nuclear reactor efficiency #74

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Fix #72 added nuclear reactor efficiency #74

merged 2 commits into from
Oct 12, 2018

Conversation

itchylol742
Copy link
Contributor

This fixes #72 by adding nuclear reactor efficiency to the nuclear ratio table. Screenshot:

image

Copy link
Owner

@deniszholob deniszholob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, also, maybe you can suggest an an icon instead of writing efficiency, idk looks a bit inconsistent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@itchylol742
Copy link
Contributor Author

I replaced the magic number and added the efficiency 3 module as an icon

@deniszholob deniszholob merged commit 4e6d9ef into deniszholob:master Oct 12, 2018
@deniszholob
Copy link
Owner

Cool, looks good, ill merge.
Thanks!

@deniszholob
Copy link
Owner

@itchylol742 Actually there is a lint issue so build is failing, please update.
https://travis-ci.org/DDDGamer/factorio-cheat-sheet/builds/440704247
run npm run build beforehand to make sure its all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add reactor efficiency in nuclear ratio
2 participants