Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HTMLElement & Update Element #21

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Introduce HTMLElement & Update Element #21

merged 1 commit into from
Feb 10, 2019

Conversation

thegrumpylion
Copy link
Contributor

  • HTMLElement with all properties implemented
  • Update Element to implement all properties
  • Elements' Style method moved to HTMLElement
  • Imput inherits from HTMLElement instead of element

Signed-off-by: Nikolas Sepos [email protected]

Copy link
Owner

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only a few small comments here:

element.go Outdated Show resolved Hide resolved
element.go Outdated Show resolved Hide resolved
* HTMLElement with all properties implemented
* Update Element to implement all properties
* Elements' Style method moved to HTMLElement
* Imput inherits from HTMLElement instead of element

Signed-off-by: Nikolas Sepos <[email protected]>
Copy link
Owner

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for all the work on this :)

@dennwc dennwc merged commit 7f87333 into dennwc:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants