fix: test_create_cache_if_dir_not_exit (#4636)

This test doesn't remove created directory after test. It will fail on next run.
denoland · Apr 6, 2020 · b9e5e4c · b9e5e4c
1 parent 1e478d7
commit b9e5e4c
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/cli/disk_cache.rs b/cli/disk_cache.rs
@@ -146,11 +146,10 @@ mod tests {
 
   #[test]
   fn test_create_cache_if_dir_not_exits() {
-    let cache_location = if cfg!(target_os = "windows") {
-      PathBuf::from(r"C:\deno_dir\foo")
-    } else {
-      PathBuf::from("~/deno_dir/foo")
-    };
+    let temp_dir = TempDir::new().unwrap();
+    let mut cache_location = temp_dir.path().to_owned();
+    assert!(fs::remove_dir(&cache_location).is_ok());
+    cache_location.push("foo");
     assert_eq!(cache_location.is_dir(), false);
     DiskCache::new(&cache_location);
     assert_eq!(cache_location.is_dir(), true);