Skip to content

Commit

Permalink
fix(install): forward granular --unstable-* flags (#22164)
Browse files Browse the repository at this point in the history
Closes #22154
  • Loading branch information
bartlomieju authored Feb 1, 2024
1 parent 6512be4 commit cfb57b1
Showing 1 changed file with 71 additions and 0 deletions.
71 changes: 71 additions & 0 deletions cli/tools/installer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,10 @@ async fn resolve_shim_data(
executable_args.push("--unstable".to_string());
}

for feature in &flags.unstable_config.features {
executable_args.push(format!("--unstable-{}", feature));
}

if flags.no_remote {
executable_args.push("--no-remote".to_string());
}
Expand Down Expand Up @@ -706,6 +710,73 @@ mod tests {
);
}

#[tokio::test]
async fn install_unstable_legacy() {
let shim_data = resolve_shim_data(
&Flags {
unstable_config: UnstableConfig {
legacy_flag_enabled: true,
..Default::default()
},
..Default::default()
},
&InstallFlags {
module_url: "http://localhost:4545/echo_server.ts".to_string(),
args: vec![],
name: None,
root: Some(env::temp_dir().to_string_lossy().to_string()),
force: false,
},
)
.await
.unwrap();

assert_eq!(shim_data.name, "echo_server");
assert_eq!(
shim_data.args,
vec![
"run",
"--unstable",
"--no-config",
"http://localhost:4545/echo_server.ts",
]
);
}

#[tokio::test]
async fn install_unstable_features() {
let shim_data = resolve_shim_data(
&Flags {
unstable_config: UnstableConfig {
features: vec!["kv".to_string(), "cron".to_string()],
..Default::default()
},
..Default::default()
},
&InstallFlags {
module_url: "http://localhost:4545/echo_server.ts".to_string(),
args: vec![],
name: None,
root: Some(env::temp_dir().to_string_lossy().to_string()),
force: false,
},
)
.await
.unwrap();

assert_eq!(shim_data.name, "echo_server");
assert_eq!(
shim_data.args,
vec![
"run",
"--unstable-kv",
"--unstable-cron",
"--no-config",
"http://localhost:4545/echo_server.ts",
]
);
}

#[tokio::test]
async fn install_inferred_name_from_parent() {
let shim_data = resolve_shim_data(
Expand Down

0 comments on commit cfb57b1

Please sign in to comment.