chore: remove protoc dep from CI (#26050)

It shouldn't be needed anymore
denoland · Oct 7, 2024 · fc293c6 · fc293c6
1 parent 9a92603
commit fc293c6
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 20 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -1,9 +1,8 @@
 FROM mcr.microsoft.com/vscode/devcontainers/rust:1-bullseye
 
-# Install cmake and protobuf-compiler
+# Install cmake
 RUN apt-get update \
   && apt-get install -y cmake \
-  && apt-get install -y protobuf-compiler \
   && rm -rf /var/lib/apt/lists/*
 
 # Install Deno

diff --git a/.github/workflows/cargo_publish.yml b/.github/workflows/cargo_publish.yml
@@ -32,12 +32,6 @@ jobs:
         with:
           deno-version: v1.x
 
-      - name: Install protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          version: '21.12'
-          repo-token: '${{ secrets.GITHUB_TOKEN }}'
-
       - name: Publish
         env:
           CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}

diff --git a/.github/workflows/ci.generate.ts b/.github/workflows/ci.generate.ts
@@ -191,11 +191,6 @@ const installNodeStep = {
   uses: "actions/setup-node@v4",
   with: { "node-version": 18 },
 };
-const installProtocStep = {
-  name: "Install protoc",
-  uses: "arduino/setup-protoc@v3",
-  with: { "version": "21.12", "repo-token": "${{ secrets.GITHUB_TOKEN }}" },
-};
 const installDenoStep = {
   name: "Install Deno",
   uses: "denoland/setup-deno@v1",
@@ -494,7 +489,6 @@ const ci = {
           if: "matrix.job == 'bench' || matrix.job == 'test'",
           ...installNodeStep,
         },
-        installProtocStep,
         {
           if: [
             "matrix.profile == 'release' &&",

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -199,12 +199,6 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 18
-      - name: Install protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          version: '21.12'
-          repo-token: '${{ secrets.GITHUB_TOKEN }}'
-        if: '!(matrix.skip)'
       - if: |-
           !(matrix.skip) && (matrix.profile == 'release' &&
           matrix.job == 'test' &&