Cannot unref() node http2 connections #16647

yzalium · 2022-11-15T10:13:50Z

Deno 1.28.0

While using npm compatibility, one of my dependencies establishes a http2 connection, and then tries to close the session calling session.unref(), which causes the following error

error: Uncaught TypeError: Cannot read properties of undefined (reading 'unref')
    at Subchannel.createSession (file:///Users/yzalium/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.7.3/build/src/subchannel.js:413:17)
    at file:///Users/yzalium/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.7.3/build/src/subchannel.js:502:18
    at Object.runMicrotasks (deno:core/01_core.js:377:30)
    at processTicksAndRejections (https://deno.land/[email protected]/node/_next_tick.ts:62:10)

This happens using the Cerbos package like so:

import { GRPC } from 'npm:@cerbos/grpc';

const client = new GRPC('localhost:3592', { tls: false })
const result = await client.checkResource({/* */})
client.close();

deno run --allow-env --allow-net --allow-write=. --allow-read=. main.ts

I've checked, and it doesn't seem like neither Cerbos nor its grpc dependency has postinstall scripts.

Thank you.

The text was updated successfully, but these errors were encountered:

spalberg · 2022-12-12T09:00:03Z

Deno 1.28.3

I get the same exception when using zeebe-node which also establishes a grpc-connection.

Since we are in the process of deciding to use either Deno or NodeJS for script and CLI application development and we need such libraries, it would be good to know if GRPC should actually work with Deno via NPM packages and this is just a bug, or if Deno generally does not support GRPC via HTTP2 in NPM packages.

c0per · 2023-01-02T08:01:05Z

Deno 1.29.1

Same exception using @grpc/grpc-js

bartlomieju · 2023-01-02T23:25:58Z

@kt3k could you take a look at this issue?

cesumilo · 2023-03-27T10:16:38Z

Little update on this issue. If you follow the quick-start guide here and setup the server using docker. Then, by running the code below:

import { GRPC } from 'npm:@cerbos/grpc';

const client = new GRPC('localhost:3593', { tls: false });
const kind = 'album:object';
const actions = ['view:public', 'comment'];

const cerbosPayload = {
  principal: {
    id: 'bugs_bunny',
    roles: ['user'],
    attributes: {
      beta_tester: true,
    },
  },
  resource: {
    kind: kind,
    id: 'BUGS001',
    attributes: {
      owner: 'bugs_bunny',
      public: false,
      flagged: false,
    },
  },
  actions: actions,
};
const decisions = await client.checkResource(cerbosPayload);
console.log(decisions);
client.close();

You get the following error:

deno run --allow-env --allow-net --allow-write=. --allow-read=. main.ts
// result: error: Uncaught NotOK: gRPC error 14 (UNAVAILABLE): No connection established

However, running the code below using ts-node works well.

import { GRPC } from '@cerbos/grpc';

(async () => {
  const client = new GRPC('localhost:3593', { tls: false });
  const kind = 'album:object';
  const actions = ['view:public', 'comment'];

  const cerbosPayload = {
    principal: {
      id: 'bugs_bunny',
      roles: ['user'],
      attributes: {
        beta_tester: true,
      },
    },
    resource: {
      kind: kind,
      id: 'BUGS001',
      attributes: {
        owner: 'bugs_bunny',
        public: false,
        flagged: false,
      },
    },
    actions: actions,
  };
  const decisions = await client.checkResource(cerbosPayload);
  console.log(decisions);
  client.close();
})();

ts-node main.ts
// result:
CheckResourcesResult {
  resource: { id: 'BUGS001', kind: 'album:object', policyVersion: '', scope: '' },
  actions: { comment: 'EFFECT_DENY', 'view:public': 'EFFECT_DENY' },
  validationErrors: [],
  metadata: undefined
}

I hope it helps! 🙏

nubunto · 2023-04-21T03:46:15Z

ran into this issue using Temporal SDK for TypeScript:

error: Uncaught TypeError: Cannot read properties of undefined (reading 'unref')
    at Subchannel.createSession (file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.7.3/build/src/subchannel.js:413:17)
    at file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.7.3/build/src/subchannel.js:502:18
    at eventLoopTick (ext:core/01_core.js:172:13)

Was able to reproduce with grpc-js as well:

✦ ❯ deno run grpcjs.ts
✅ Granted read access to "foo.proto".
error: Uncaught TypeError: Cannot read properties of undefined (reading 'setTimeout')
    at setupServer (file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.8.14/build/src/server.js:269:25)
    at file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.8.14/build/src/server.js:289:37
    at Array.map (<anonymous>)
    at bindSpecificPort (file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.8.14/build/src/server.js:277:44)
    at Object.onSuccessfulResolution (file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.8.14/build/src/server.js:419:45)
    at Timeout._onTimeout (file:///Users/nubunto/Library/Caches/deno/npm/registry.npmjs.org/@grpc/grpc-js/1.8.14/build/src/resolver-dns.js:128:31)
    at cb (ext:deno_node/internal/timers.mjs:37:46)
    at Object.action (ext:deno_web/02_timers.js:147:11)
    at handleTimerMacrotask (ext:deno_web/02_timers.js:64:10)
    at eventLoopTick (ext:core/01_core.js:171:21)

Seems like an issue when loading Node's http2 package?

NfNitLoop · 2023-07-07T18:56:35Z

Ran into this issue as well with Deno 1.35, when trying to use Google's SecretManagerService, which uses gRPC and so needs http/2 support:

Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.unref
Warning: Not implemented: Http2Session.ref
error: Uncaught TypeError: error sending request for url (http://secretmanager.googleapis.com:443/google.cloud.secretmanager.v1.SecretManagerService/GetSecret): connection error: Connection reset by peer (os error 54)
    at async mainFetch (ext:deno_fetch/26_fetch.js:266:12)
    at async fetch (ext:deno_fetch/26_fetch.js:490:7)
    at async node:http2:144:28

Steps to reproduce:

Unfortunately, you have to have valid gcloud credentials locally, else we fail before even making a connection:

install gcloud CLI
gcloud auth application-default login

import {SecretManagerServiceClient as Client} from "npm:@google-cloud/secret-manager"

const client = new Client({ projectId: "my-project"})
const secret = await client.getSecret({name: "my-secret"})

oleggromov · 2023-07-31T01:51:38Z

Having the same issue here as @NfNitLoop

bartlomieju · 2023-07-31T09:55:08Z

I am currently working on improving support for node:http2 module specifically to support @google-cloud package.

jotacamou · 2023-08-17T18:15:52Z

Just for the sake of reporting, I'm also experiencing the same issue with Deno v1.36.1 while trying to use the @google-cloud/secret-manager package.

cesumilo · 2023-09-04T15:41:23Z

Same here, experiencing the issue with @google-cloud/pubsub, I hope it will be fixed soon 🙏

This commit improves "node:http2" module implementation, by enabling to use "options.createConnection" callback when starting an HTTP2 session. This change enables to pass basic client-side test with "grpc-js/grpc" package. Smaller fixes like "Http2Session.unref()" and "Http2Session.setTimeout()" were handled as well. Fixes #16647

samrocksc · 2023-12-21T08:44:38Z

Just checked this morning with 1.39:

Google Pub/Sub => same issue
Google Secret Manager => same issue

mpcref · 2024-09-15T13:52:22Z

Same issue here:

✗ deno -v
deno 2.0.0-rc.2

✗ deno run -A npm:trigger.dev@beta login

Trigger.dev (3.0.0-beta.56)

T  Logging in to Trigger.dev
|
o  Created authorization code
|
o  Please visit the following URL to login:
|  https://cloud.trigger.dev/account/authorization-code/Ws6oxuBRDovT7O0m4c1rzz_Gmb-6Zomzm7hGtqnYdQqkuFK3Lvsi62VLnamWi4bC
X Error: Cannot read properties of undefined (reading 'unref')

dsherret added bug Something isn't working correctly node compat labels Nov 17, 2022

kt3k self-assigned this Jan 4, 2023

bartlomieju mentioned this issue Apr 25, 2023

npm compat tracking issue - April 2023 #18836

Closed

9 tasks

tigitz mentioned this issue May 12, 2023

"node:http" doesn't implement "Server.unref()" API #19113

Closed

bartlomieju assigned bartlomieju and unassigned kt3k Oct 1, 2023

bartlomieju mentioned this issue Oct 1, 2023

fix(node/http2): fixes to support grpc #20712

Merged

bartlomieju closed this as completed in #20712 Oct 12, 2023

tenkoverse mentioned this issue Nov 22, 2023

Not implemented: Http2Session.socket #20903

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot unref() node http2 connections #16647

Cannot unref() node http2 connections #16647

yzalium commented Nov 15, 2022

spalberg commented Dec 12, 2022 •

edited

Loading

c0per commented Jan 2, 2023

bartlomieju commented Jan 2, 2023

cesumilo commented Mar 27, 2023

nubunto commented Apr 21, 2023

NfNitLoop commented Jul 7, 2023

oleggromov commented Jul 31, 2023

bartlomieju commented Jul 31, 2023

jotacamou commented Aug 17, 2023 •

edited

Loading

cesumilo commented Sep 4, 2023

samrocksc commented Dec 21, 2023

mpcref commented Sep 15, 2024 •

edited

Loading

Cannot unref() node http2 connections #16647

Cannot unref() node http2 connections #16647

Comments

yzalium commented Nov 15, 2022

spalberg commented Dec 12, 2022 • edited Loading

c0per commented Jan 2, 2023

bartlomieju commented Jan 2, 2023

cesumilo commented Mar 27, 2023

nubunto commented Apr 21, 2023

NfNitLoop commented Jul 7, 2023

oleggromov commented Jul 31, 2023

bartlomieju commented Jul 31, 2023

jotacamou commented Aug 17, 2023 • edited Loading

cesumilo commented Sep 4, 2023

samrocksc commented Dec 21, 2023

mpcref commented Sep 15, 2024 • edited Loading

spalberg commented Dec 12, 2022 •

edited

Loading

jotacamou commented Aug 17, 2023 •

edited

Loading

mpcref commented Sep 15, 2024 •

edited

Loading