-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/build.rs requires glibc on Linux #17739
Comments
jirutka
added a commit
to jirutka/deno
that referenced
this issue
Jul 23, 2023
musl supports dynamic list. This patch comes from https://github.com/12101111/overlay/blob/cb58b125ada1d11c0309da144309628c5670af46/dev-lang/deno/files/glibc.patch. Resolves denoland#17739 Co-Authored-By: 12101111 <[email protected]>
jirutka
added a commit
to jirutka/deno
that referenced
this issue
Jul 23, 2023
…oland#17739) musl supports dynamic list. This patch comes from https://github.com/12101111/overlay/blob/cb58b125ada1d11c0309da144309628c5670af46/dev-lang/deno/files/glibc.patch. Resolves denoland#17739 Co-Authored-By: 12101111 <[email protected]>
jirutka
added a commit
to jirutka/deno
that referenced
this issue
Jul 23, 2023
musl supports dynamic list. This patch comes from https://github.com/12101111/overlay/blob/cb58b125ada1d11c0309da144309628c5670af46/dev-lang/deno/files/glibc.patch. Resolves denoland#17739 Co-Authored-By: 12101111 <[email protected]>
mmastrac
pushed a commit
that referenced
this issue
Jul 23, 2023
) musl supports dynamic list. This patch comes from https://github.com/12101111/overlay/blob/cb58b125ada1d11c0309da144309628c5670af46/dev-lang/deno/files/glibc.patch. Resolves #17739 Note: This patch is already used in Alpine Linux’s [deno](https://pkgs.alpinelinux.org/packages?name=deno) package. Co-authored-by: 12101111 <[email protected]>
mmastrac
pushed a commit
that referenced
this issue
Jul 26, 2023
) musl supports dynamic list. This patch comes from https://github.com/12101111/overlay/blob/cb58b125ada1d11c0309da144309628c5670af46/dev-lang/deno/files/glibc.patch. Resolves #17739 Note: This patch is already used in Alpine Linux’s [deno](https://pkgs.alpinelinux.org/packages?name=deno) package. Co-authored-by: 12101111 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
build.rs
hard-depends on being able to loadglibc
in order to set linker flags (Line 430):Correcting this is the only source code change I needed to successfully build Deno on Alpine/musl x86_64 and will help address #3711. I would submit a PR directly but am not sure what the best fix here is; the failure is that
unwrap()
fails, because glibc can't be loaded; in my build I removed all the conditionals and the glibc call here so that it just uses the dynamic symbol list without checking.Maybe if glibc is missing assume it's good enough? Or should MUSL-building code set
CC
? That will still require a source edit, because currentlyglibc
is checked beforeCC
. This whole block could also be made dependent on the target also being GNU.The text was updated successfully, but these errors were encountered: